You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/26 10:24:17 UTC
[GitHub] [lucene-site] janhoy opened a new pull request #15: Conditionally
show security warning block only if news last 60 days.
janhoy opened a new pull request #15: Conditionally show security warning block only if news last 60 days.
URL: https://github.com/apache/lucene-site/pull/15
SOLR-13910 followup
This PR converts from static calculation in Pelican of age for last secuity news, to dynamic calculation in JS, so the yellow warning box goes away without re-publish.
I also chose 60 days as "recent" instead of 90 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-site] uschindler commented on issue #15: Conditionally show
security warning block only if news last 60 days.
Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #15: Conditionally show security warning block only if news last 60 days.
URL: https://github.com/apache/lucene-site/pull/15#issuecomment-594757081
Oh thanks for doing this. I was on vacation. I had something similar in mind. Cool done with the attribute on root element.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-site] janhoy commented on a change in pull request #15:
Conditionally show security warning block only if news last 60 days.
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #15: Conditionally show security warning block only if news last 60 days.
URL: https://github.com/apache/lucene-site/pull/15#discussion_r384401449
##########
File path: .editorconfig
##########
@@ -6,13 +6,7 @@ end_of_line = lf
insert_final_newline = true
indent_style = space
charset = utf-8
-indent_size = 4
+indent_size = 2
Review comment:
I did this because all JS is also indent of 2, so it appears that this should be the default so we can remove the override sections further down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-site] janhoy merged pull request #15: Conditionally show
security warning block only if news last 60 days.
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #15: Conditionally show security warning block only if news last 60 days.
URL: https://github.com/apache/lucene-site/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org