You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2015/12/04 23:51:41 UTC

Review Request 40994: Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40994/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, jun aoki, and Oleksandr Diachenko.


Bugs: AMBARI-14208
    https://issues.apache.org/jira/browse/AMBARI-14208


Repository: ambari


Description
-------

Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster


Diffs
-----

  ambari-web/app/controllers/wizard/step7_controller.js c9d3da7 
  ambari-web/test/controllers/wizard/step7_test.js bba552a 

Diff: https://reviews.apache.org/r/40994/diff/


Testing
-------

yes

  10886 tests complete (14 seconds)
  108 tests pending
  
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS


Thanks,

bhuvnesh chaudhary


Re: Review Request 40994: Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster

Posted by Bhuvnesh Chaudhary <bc...@pivotal.io>.
Team,

For your review.

Thanks,
Bhuvnesh Chaudhary
Email: bchau <bc...@gopivotal.com>dhary@pivotal.io
Desk: +1-650-846-1696 | Mobile: +1-973-906-6976

On Fri, Dec 4, 2015 at 2:51 PM, bhuvnesh chaudhary <bc...@pivotal.io>
wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40994/
> Review request for Ambari, Alejandro Fernandez, jun aoki, and Oleksandr
> Diachenko.
> By bhuvnesh chaudhary.
> *Bugs: * AMBARI-14208 <https://issues.apache.org/jira/browse/AMBARI-14208>
> *Repository: * ambari
> Description
>
> Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster
>
> Testing
>
> yes
>
> 10886 tests complete (14 seconds)
>   108 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
> Diffs
>
>    - ambari-web/app/controllers/wizard/step7_controller.js (c9d3da7)
>    - ambari-web/test/controllers/wizard/step7_test.js (bba552a)
>
> View Diff <https://reviews.apache.org/r/40994/diff/>
>

Re: Review Request 40994: Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster

Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40994/#review109251
-----------------------------------------------------------

Ship it!


Ship It!

- Oleksandr Diachenko


On Dec. 4, 2015, 10:54 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40994/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 10:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-14208
>     https://issues.apache.org/jira/browse/AMBARI-14208
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step7_controller.js c9d3da7 
>   ambari-web/test/controllers/wizard/step7_test.js bba552a 
> 
> Diff: https://reviews.apache.org/r/40994/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
>   10886 tests complete (14 seconds)
>   108 tests pending
>   
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 40994: Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40994/#review109369
-----------------------------------------------------------



ambari-web/app/controllers/wizard/step7_controller.js (line 927)
<https://reviews.apache.org/r/40994/#comment168865>

    Please include Jaimin Jetly and Richard Zang in this code review.


- Alejandro Fernandez


On Dec. 4, 2015, 10:54 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40994/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 10:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-14208
>     https://issues.apache.org/jira/browse/AMBARI-14208
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step7_controller.js c9d3da7 
>   ambari-web/test/controllers/wizard/step7_test.js bba552a 
> 
> Diff: https://reviews.apache.org/r/40994/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
>   10886 tests complete (14 seconds)
>   108 tests pending
>   
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 40994: Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40994/
-----------------------------------------------------------

(Updated Dec. 4, 2015, 10:54 p.m.)


Review request for Ambari, Alejandro Fernandez, jun aoki, and Oleksandr Diachenko.


Bugs: AMBARI-14208
    https://issues.apache.org/jira/browse/AMBARI-14208


Repository: ambari


Description
-------

Update hawq_dfs_url with nameservice when hawq is installed on a ha cluster


Diffs (updated)
-----

  ambari-web/app/controllers/wizard/step7_controller.js c9d3da7 
  ambari-web/test/controllers/wizard/step7_test.js bba552a 

Diff: https://reviews.apache.org/r/40994/diff/


Testing
-------

yes

  10886 tests complete (14 seconds)
  108 tests pending
  
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS


Thanks,

bhuvnesh chaudhary