Re: [PR] Allow cleaning up of networks stuck in Implementing state [cloudstack]

["winterhazel (via GitHub)" <gi...@apache.org>]

winterhazel commented on code in PR #12409:
URL: https://github.com/apache/cloudstack/pull/12409#discussion_r3282833144


##########
framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java:
##########
@@ -1284,6 +1296,74 @@ private void cleanupFailedSnapshotsCreatedWithDefaultStrategy(final long msid) {
         }
     }
 
+    /**
+     * Cleanup networks that are stuck in Implementing state without associated async jobs.
+     * This only processes networks that have been stuck for longer than the job expiration threshold.
+     */
+    private void cleanupOrphanedNetworks() {
+        try {

Review Comment:
   Can we remove this `try`, as there is already one in `cleanupNetworksStuckInImplementing()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org