[GitHub] [cassandra] aweisberg commented on a diff in pull request #2049: CASSANDRA-18100 CAS and serial read support for Accord

[GitBox <gi...@apache.org>]

aweisberg commented on code in PR #2049:
URL: https://github.com/apache/cassandra/pull/2049#discussion_r1061886671


##########
src/java/org/apache/cassandra/service/accord/txn/TxnData.java:
##########
@@ -75,6 +75,7 @@ public Set<Map.Entry<TxnDataName, FilteredPartition>> entrySet()
         return data.entrySet();
     }
 
+    // This is inadequate

Review Comment:
   I need to remove this. Accord does single replica reads so no need to merge duplicates.
   
   For live migration Cassandra will probably coordinate quorum reads for Accord so the merging will already be done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org