You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sarutak <gi...@git.apache.org> on 2014/09/03 11:49:28 UTC
[GitHub] spark pull request: [SPARK-3372] [MLLIB] Scalastyle fails due to U...
GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/2248
[SPARK-3372] [MLLIB] Scalastyle fails due to UTF-8 character being contained in Gradient.scala
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarutak/spark SPARK-3372
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2248
----
commit 73a28b8edf79a6aae7260e514d5b68a438e34ba1
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date: 2014-09-03T09:48:12Z
Replaced UTF-8 hyphen with ascii hyphen
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3372] [MLLIB] Scalastyle fails due to U...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2248#issuecomment-54280386
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19657/consoleFull) for PR 2248 at commit [`73a28b8`](https://github.com/apache/spark/commit/73a28b8edf79a6aae7260e514d5b68a438e34ba1).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3372] [MLlib] MLlib doesn't pass maven ...
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/2248#issuecomment-54481336
@mengxr Thank you for picking up this PR.
My colleague tried to build on Windows8 with "mvn package" and then failed to build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3372] [MLlib] MLlib doesn't pass maven ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2248#issuecomment-54401616
@sarutak Nice catch! I'm merging this into master and branch-1.1. Thanks!
Btw, maven scalastyle doesn't fail on my machine (OSX). Which OS are you using?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3372] [MLlib] MLlib doesn't pass maven ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3372] [MLLIB] Scalastyle fails due to U...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2248#issuecomment-54274677
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19657/consoleFull) for PR 2248 at commit [`73a28b8`](https://github.com/apache/spark/commit/73a28b8edf79a6aae7260e514d5b68a438e34ba1).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org