You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/30 22:38:30 UTC
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9487: [feature] coalesce scalar
Jackie-Jiang commented on code in PR #9487:
URL: https://github.com/apache/pinot/pull/9487#discussion_r984985384
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java:
##########
@@ -18,13 +18,24 @@
*/
package org.apache.pinot.common.function.scalar;
+import java.util.Arrays;
+import java.util.List;
import javax.annotation.Nullable;
import org.apache.pinot.spi.annotations.ScalarFunction;
public class ObjectFunctions {
private ObjectFunctions() {
}
+ private static Object coalesce(List<Object> objects) {
Review Comment:
```suggestion
private static Object coalesce(Object... objects) {
```
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java:
##########
@@ -18,13 +18,24 @@
*/
package org.apache.pinot.common.function.scalar;
+import java.util.Arrays;
+import java.util.List;
import javax.annotation.Nullable;
import org.apache.pinot.spi.annotations.ScalarFunction;
public class ObjectFunctions {
private ObjectFunctions() {
}
+ private static Object coalesce(List<Object> objects) {
Review Comment:
Annotate it as `@Nullable`, same for other functions
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java:
##########
@@ -18,13 +18,24 @@
*/
package org.apache.pinot.common.function.scalar;
+import java.util.Arrays;
+import java.util.List;
import javax.annotation.Nullable;
import org.apache.pinot.spi.annotations.ScalarFunction;
public class ObjectFunctions {
private ObjectFunctions() {
}
+ private static Object coalesce(List<Object> objects) {
Review Comment:
(minor) Move it to the end following the other coalesce functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org