[ofbiz-framework] 03/05: Improved: Remove unnecessary ‘ofbizDebug’ task type (OFBIZ-11302)

[mt...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mthl pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git

commit 22f1da78590d7907a64f7b543670c56ddd4c1769
Author: Mathieu Lirzin <ma...@nereide.fr>
AuthorDate: Sat Nov 30 02:04:55 2019 +0100

    Improved: Remove unnecessary ‘ofbizDebug’ task type (OFBIZ-11302)
    
    the standard ‘--debug-jvm’ Gradle option already provides the same
    functionality.
---
 README.adoc  | 13 ++++---------
 build.gradle |  7 -------
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/README.adoc b/README.adoc
index 7019362..b4dd654 100644
--- a/README.adoc
+++ b/README.adoc
@@ -149,7 +149,6 @@ There are two types of tasks designed for OFBiz in Gradle:
 * *OFBiz server tasks*: To execute OFBiz startup commands. These tasks start
 with one of the following words:
 * *ofbiz* : standard server commands
-* *ofbizDebug* : server commands running in remote debug mode
 * *ofbizBackground* ; server commands running in a background forked process
 
 Tips:
@@ -175,7 +174,7 @@ tasks. Example: `gradlew loadAdminUserLogin -PuserLoginId=myadmin` =
 
 `gradlew "ofbiz --help"`
 
-`gradlew "ofbizDebug --test"`
+`gradlew "ofbiz --test" --debug-jvm`
 
 `gradlew "ofbizBackground --start --portoffset 10000"`
 
@@ -273,11 +272,7 @@ inconsistent state / data
 Starts OFBiz in remote debug mode and waits for debugger or IDEs to connect on
 port *5005*
 
-`gradlew "ofbizDebug --start"`
-
-OR
-
-`gradlew ofbizDebug`
+`gradlew ofbiz --debug-jvm`
 
 [[start-ofbiz-on-a-different-port]]
 ==== Start OFBiz on a different port
@@ -514,7 +509,7 @@ run a test case, in this example the component is "entity" and the case name is
 
 listens on port *5005*
 
-`gradlew "ofbizDebug --test component=entity --test loglevel=verbose"`
+`gradlew "ofbiz --test component=entity --test loglevel=verbose" --debug-jvm`
 
 [[execute-an-integration-test-suite]]
 ==== Execute an integration test suite
@@ -526,7 +521,7 @@ listens on port *5005*
 
 listens on port *5005*
 
-`gradlew "ofbizDebug --test component=entity --test suitename=entitytests"`
+`gradlew "ofbiz --test component=entity --test suitename=entitytests" --debug-jvm`
 
 
 
diff --git a/build.gradle b/build.gradle
index 98c7d93..b8465bc 100644
--- a/build.gradle
+++ b/build.gradle
@@ -963,13 +963,6 @@ tasks.addRule('Pattern: ofbiz <Commands>: Execute OFBiz startup commands') { Str
     }
 }
 
-tasks.addRule('Pattern: ofbizDebug <Commands>: Execute OFBiz startup commands in remote debug mode') { String taskName ->
-    if (taskName ==~ /^ofbizDebug\s.*/ || taskName == 'ofbizDebug') {
-        def arguments = (taskName - 'ofbizDebug').tokenize(' ')
-        createOfbizCommandTask(taskName, arguments).with { debug = true }
-    }
-}
-
 tasks.addRule('Pattern: ofbizBackground <Commands>: Execute OFBiz startup commands in background and output to console.log') { String taskName ->
     if (taskName ==~ /^ofbizBackground\s.*/ || taskName == 'ofbizBackground') {
         createOfbizBackgroundCommandTask(taskName)