You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sadanand48 (via GitHub)" <gi...@apache.org> on 2024/04/08 12:12:46 UTC
[PR] Hdds 10628 [ozone]
sadanand48 opened a new pull request, #6494:
URL: https://github.com/apache/ozone/pull/6494
## What changes were proposed in this pull request?
Safe mode rules are not calculated/updated after a safemode force exit, If a user looks at the SCM web UI after a force exit , it would give an impression that SCM is in safemode by looking at the rules not being satisfied.
Displaying if safe mode was forcefully exited will be helpful in this case.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10628
## How was this patch tested?
Manually
<img width="1392" alt="Screenshot 2024-04-08 at 4 59 22 PM" src="https://github.com/apache/ozone/assets/31859223/86e6bc44-155b-4b91-b54c-aad253244cf0">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10628. Display if safemode exit was via force exit command. [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #6494:
URL: https://github.com/apache/ozone/pull/6494#discussion_r1575875166
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java:
##########
@@ -319,6 +323,14 @@ public void setPreCheckComplete(boolean newState) {
this.preCheckComplete.set(newState);
}
+ public boolean isSafeModeExitForceful() {
+ return forceExitSafeMode.get();
+ }
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10628. Display if safemode exit was via force exit command. [ozone]
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #6494:
URL: https://github.com/apache/ozone/pull/6494#discussion_r1569256471
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java:
##########
@@ -319,6 +323,14 @@ public void setPreCheckComplete(boolean newState) {
this.preCheckComplete.set(newState);
}
+ public boolean isSafeModeExitForceful() {
+ return forceExitSafeMode.get();
+ }
Review Comment:
the name of the variable is ``forceExitSafeMode`` the setter is also ``setForceExitSafeMode`` can we keep this method name in line: ``isForceExitSafeMode()``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10628. Display if safemode exit was via force exit command. [ozone]
Posted by "myskov (via GitHub)" <gi...@apache.org>.
myskov commented on code in PR #6494:
URL: https://github.com/apache/ozone/pull/6494#discussion_r1556088744
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java:
##########
@@ -319,6 +328,14 @@ public void setPreCheckComplete(boolean newState) {
this.preCheckComplete.set(newState);
}
+ public boolean getForceExitSafeMode() {
Review Comment:
seems to be a duplicate of isSafeModeExitForceful()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10628. Display if safemode exit was via force exit command. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #6494:
URL: https://github.com/apache/ozone/pull/6494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10628. Display if safemode exit was via force exit command. [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #6494:
URL: https://github.com/apache/ozone/pull/6494#issuecomment-2043170456
cc @Tejaskriya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10628. Display if safemode exit was via force exit command. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #6494:
URL: https://github.com/apache/ozone/pull/6494#discussion_r1577330912
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java:
##########
@@ -319,6 +328,14 @@ public void setPreCheckComplete(boolean newState) {
this.preCheckComplete.set(newState);
}
+ public boolean getForceExitSafeMode() {
Review Comment:
This is addressed in b4cf6aa241d3017f58d27d9fc114d8e9362005d5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10628. Display if safemode exit was via force exit command. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #6494:
URL: https://github.com/apache/ozone/pull/6494#issuecomment-2074154793
Thanks @sadanand48 for the patch, @ayushtkn, @myskov, @sumitagrawl, @Tejaskriya for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org