[GitHub] [doris] zhannngchen commented on a diff in pull request #11289: [feature-wip](unique-key-merge-on-write) update bitmap after compaction, DSIP-018

[GitBox <gi...@apache.org>]

zhannngchen commented on code in PR #11289:
URL: https://github.com/apache/doris/pull/11289#discussion_r932107099


##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +734,45 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
     return Status::OK();
 }
 
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset, but the

Review Comment:
   we take a delete bitmap's snapshot of origin rowset at the beginning of compaction



##########
be/src/olap/tablet_meta.cpp:
##########
@@ -734,6 +734,45 @@ Status TabletMeta::set_partition_id(int64_t partition_id) {
     return Status::OK();
 }
 
+// update dst rowset delete bitmap for unique key merge on write table.
+// we take a delete bitmap's snapshot of origin rowset, but the
+// detele bitmap of origin rowset may update when compaction.
+// some key deleted on compaction will exist in dst rowset.

Review Comment:
   some key might be deleted during compaction, which would exist in dst rowset.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org