You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2026/03/22 03:11:20 UTC
[PR] Add Request Interceptors for Javascript [tinkerpop]
Cole-Greer opened a new pull request, #3337:
URL: https://github.com/apache/tinkerpop/pull/3337
This PR adds request interceptors for Javascript, modeled after the interceptors which have already been added to Python. There are 2 reference implementations of interceptors to provide both `basic` and `sigv4` auth. Additionally the configuration of serializers has been refactored, with the old `mimeType` connection option removed in favour of direct use of `writer` and `reader` (consistent with other GLVs). The writer has additionally become optional to grant additional flexibility if users wish to run an interceptor on an un-serialized request body.
My vote is VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Request Interceptors for Javascript [tinkerpop]
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on code in PR #3337:
URL: https://github.com/apache/tinkerpop/pull/3337#discussion_r2977384292
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/auth.ts:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
Review Comment:
small nit: i recently normalized license headers across the code base using the standard text the ASF has. for some reason, coding agents are writing their own weird stuff in there. anyway, this is the format to user here: https://github.com/apache/tinkerpop/blob/master/bin/asf-license-header.txt also, the https://github.com/apache/tinkerpop/blob/master/bin/fix-license-headers.py script can help clean this stuff up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Request Interceptors for Javascript [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #3337:
URL: https://github.com/apache/tinkerpop/pull/3337#issuecomment-4112131042
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Request Interceptors for Javascript [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #3337:
URL: https://github.com/apache/tinkerpop/pull/3337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Request Interceptors for Javascript [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #3337:
URL: https://github.com/apache/tinkerpop/pull/3337#issuecomment-4113942697
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org