You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/02 06:39:17 UTC

[GitHub] [pulsar] rdhabalia commented on a change in pull request #13074: [pulsar-broker] Make load-balancer config dynamic for the runtime tuning

rdhabalia commented on a change in pull request #13074:
URL: https://github.com/apache/pulsar/pull/13074#discussion_r760798828



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1722,6 +1723,7 @@
 
     @FieldContext(
             category = CATEGORY_LOAD_BALANCER,
+            dynamic = true,
             doc = "load balance load shedding strategy"
     )
     private String loadBalancerLoadSheddingStrategy = "org.apache.pulsar.broker.loadbalance.impl.OverloadShedder";

Review comment:
       we would like to change config without deploying new code and dynamic config helps in that case. for a safe deployment we would like keep existing config, change config dynamically and do process restart without redeploying new code.  so, this is an intentional code change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org