[jira] [Commented] (HBASE-15160) Put back HFile's HDFS op latency sampling code and add metrics for monitoring

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174896#comment-15174896 ] 

Enis Soztutar commented on HBASE-15160:
---------------------------------------

This is still important to get in if we can quantify the perf effect. 

bq. Rather than storing the times, we should just put them into a histogram in the metrics system.
[~carp84] did you see Elliott's review comment above. Using histograms that we use elsewhere is the correct way to go. 

> Put back HFile's HDFS op latency sampling code and add metrics for monitoring
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-15160
>                 URL: https://issues.apache.org/jira/browse/HBASE-15160
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0, 1.1.2
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-15160.patch, HBASE-15160_v2.patch, HBASE-15160_v3.patch
>
>
> In HBASE-11586 all HDFS op latency sampling code, including fsReadLatency, fsPreadLatency and fsWriteLatency, have been removed. There was some discussion about putting them back in a new JIRA but never happened. According to our experience, these metrics are useful to judge whether issue lies on HDFS when slow request occurs, so we propose to put them back in this JIRA, and add the metrics for monitoring as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)