You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/16 09:02:48 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #2220: Ref gitlab conn id mr 1
warren830 opened a new pull request, #2220:
URL: https://github.com/apache/incubator-devlake/pull/2220
# Summary
Refactor gitlab mr tasks with connection_id
Add e2e test
### Does this close any open issues?
Please mention the issues here.
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2220: Ref gitlab conn id mr 1
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #2220:
URL: https://github.com/apache/incubator-devlake/pull/2220#discussion_r898954766
##########
plugins/gitlab/tasks/mr_extractor.go:
##########
@@ -102,6 +102,7 @@ func ExtractApiMergeRequests(taskCtx core.SubTaskContext) error {
AvatarUrl: reviewer.AvatarUrl,
WebUrl: reviewer.WebUrl,
}
+ gitlabReviewer.ConnectionId = data.Options.ConnectionId
Review Comment:
why not added in line 96?
##########
plugins/gitlab/tasks/mr_enricher.go:
##########
@@ -40,7 +40,7 @@ func EnrichMergeRequests(taskCtx core.SubTaskContext) error {
db := taskCtx.GetDal()
clauses := []dal.Clause{
dal.From(&models.GitlabMergeRequest{}),
- dal.Where("project_id=?", data.Options.ProjectId),
+ dal.Where("project_id=? and connection_id = ?", data.Options.ProjectId, data.Options.ConnectionId),
}
cursor, err := db.Cursor(clauses...)
Review Comment:
Line 63 and Line75 need to be added " and connection_id = ?"
##########
plugins/jira/jira.go:
##########
@@ -168,6 +168,7 @@ func (plugin Jira) MigrationScripts() []migration.Script {
new(migrationscripts.UpdateSchemas20220527),
new(migrationscripts.UpdateSchemas20220601),
new(migrationscripts.UpdateSchemas20220614),
+ new(migrationscripts.UpdateSchemas20220616),
Review Comment:
what's this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2220: Ref gitlab conn id mr 1
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2220:
URL: https://github.com/apache/incubator-devlake/pull/2220#discussion_r899066386
##########
plugins/jira/jira.go:
##########
@@ -168,6 +168,7 @@ func (plugin Jira) MigrationScripts() []migration.Script {
new(migrationscripts.UpdateSchemas20220527),
new(migrationscripts.UpdateSchemas20220601),
new(migrationscripts.UpdateSchemas20220614),
+ new(migrationscripts.UpdateSchemas20220616),
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mindlesscloud merged pull request #2220: Ref gitlab conn id mr 1
Posted by GitBox <gi...@apache.org>.
mindlesscloud merged PR #2220:
URL: https://github.com/apache/incubator-devlake/pull/2220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org