You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2006/06/01 14:03:16 UTC
[jira] Created: (SB-27) tiles:insert tag does not try to guess the
type of attribute
tiles:insert tag does not try to guess the type of attribute
------------------------------------------------------------
Key: SB-27
URL: http://issues.apache.org/struts/browse/SB-27
Project: Sandbox
Type: Bug
Components: Standalone Tiles
Versions: 1.0
Environment: Windows 2000 and Linux (Ubuntu Breezy), JDK 1.5.0_06, Tomcat 5.5.17
Reporter: Antonio Petrelli
Priority: Minor
The <tiles:insert> (i.e. its implementation InsertTag) does not try to guess the type of an attribute if the type is not specified.
Therefore, if the type is not there, a null value is returned as the value of the attribute, so that nothing is displayed.
I posted a patch to solve this issue, though I am not sure if "page" is a good type for an attribute that has the form "/somewhere/somewhat.jsp".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Work started: (SB-27) tiles:insert tag does not try to guess
the type of attribute
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-27?page=all ]
Work on SB-27 started by Antonio Petrelli.
> tiles:insert tag does not try to guess the type of attribute
> ------------------------------------------------------------
>
> Key: SB-27
> URL: http://issues.apache.org/struts/browse/SB-27
> Project: Sandbox
> Issue Type: Bug
> Components: Tiles
> Affects Versions: 2.0
> Environment: Windows 2000 and Linux (Ubuntu Breezy), JDK 1.5.0_06, Tomcat 5.5.17
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Priority: Minor
> Attachments: it_patch.diff
>
>
> The <tiles:insert> (i.e. its implementation InsertTag) does not try to guess the type of an attribute if the type is not specified.
> Therefore, if the type is not there, a null value is returned as the value of the attribute, so that nothing is displayed.
> I posted a patch to solve this issue, though I am not sure if "page" is a good type for an attribute that has the form "/somewhere/somewhat.jsp".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work stopped: (SB-27) tiles:insert tag does not try to guess
the type of attribute
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-27?page=all ]
Work on SB-27 stopped by Antonio Petrelli.
> tiles:insert tag does not try to guess the type of attribute
> ------------------------------------------------------------
>
> Key: SB-27
> URL: http://issues.apache.org/struts/browse/SB-27
> Project: Sandbox
> Issue Type: Bug
> Components: Tiles
> Affects Versions: 2.0
> Environment: Windows 2000 and Linux (Ubuntu Breezy), JDK 1.5.0_06, Tomcat 5.5.17
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Priority: Minor
> Attachments: it_patch.diff
>
>
> The <tiles:insert> (i.e. its implementation InsertTag) does not try to guess the type of an attribute if the type is not specified.
> Therefore, if the type is not there, a null value is returned as the value of the attribute, so that nothing is displayed.
> I posted a patch to solve this issue, though I am not sure if "page" is a good type for an attribute that has the form "/somewhere/somewhat.jsp".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SB-27) tiles:insert tag does not try to guess the
type of attribute
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-27?page=all ]
Antonio Petrelli updated SB-27:
-------------------------------
Attachment: it_patch.diff
This patch solves the problem
> tiles:insert tag does not try to guess the type of attribute
> ------------------------------------------------------------
>
> Key: SB-27
> URL: http://issues.apache.org/struts/browse/SB-27
> Project: Sandbox
> Type: Bug
> Components: Standalone Tiles
> Versions: 1.0
> Environment: Windows 2000 and Linux (Ubuntu Breezy), JDK 1.5.0_06, Tomcat 5.5.17
> Reporter: Antonio Petrelli
> Priority: Minor
> Attachments: it_patch.diff
>
> The <tiles:insert> (i.e. its implementation InsertTag) does not try to guess the type of an attribute if the type is not specified.
> Therefore, if the type is not there, a null value is returned as the value of the attribute, so that nothing is displayed.
> I posted a patch to solve this issue, though I am not sure if "page" is a good type for an attribute that has the form "/somewhere/somewhat.jsp".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (SB-27) tiles:insert tag does not try to guess the
type of attribute
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-27?page=all ]
Antonio Petrelli resolved SB-27.
--------------------------------
Fix Version/s: 2.0
Resolution: Fixed
Modified InsertTag class with a modified patch: as suggested by Greg I replaced "page" with "template"
> tiles:insert tag does not try to guess the type of attribute
> ------------------------------------------------------------
>
> Key: SB-27
> URL: http://issues.apache.org/struts/browse/SB-27
> Project: Sandbox
> Issue Type: Bug
> Components: Tiles
> Affects Versions: 2.0
> Environment: Windows 2000 and Linux (Ubuntu Breezy), JDK 1.5.0_06, Tomcat 5.5.17
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Priority: Minor
> Fix For: 2.0
>
> Attachments: it_patch.diff
>
>
> The <tiles:insert> (i.e. its implementation InsertTag) does not try to guess the type of an attribute if the type is not specified.
> Therefore, if the type is not there, a null value is returned as the value of the attribute, so that nothing is displayed.
> I posted a patch to solve this issue, though I am not sure if "page" is a good type for an attribute that has the form "/somewhere/somewhat.jsp".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (SB-27) tiles:insert tag does not try to guess the
type of attribute
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-27?page=all ]
Antonio Petrelli reassigned SB-27:
----------------------------------
Assignee: Antonio Petrelli
> tiles:insert tag does not try to guess the type of attribute
> ------------------------------------------------------------
>
> Key: SB-27
> URL: http://issues.apache.org/struts/browse/SB-27
> Project: Sandbox
> Issue Type: Bug
> Components: Tiles
> Affects Versions: 2.0
> Environment: Windows 2000 and Linux (Ubuntu Breezy), JDK 1.5.0_06, Tomcat 5.5.17
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Priority: Minor
> Attachments: it_patch.diff
>
>
> The <tiles:insert> (i.e. its implementation InsertTag) does not try to guess the type of an attribute if the type is not specified.
> Therefore, if the type is not there, a null value is returned as the value of the attribute, so that nothing is displayed.
> I posted a patch to solve this issue, though I am not sure if "page" is a good type for an attribute that has the form "/somewhere/somewhat.jsp".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SB-27) tiles:insert tag does not try to guess
the type of attribute
Posted by "Greg Reddin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-27?page=comments#action_37887 ]
Greg Reddin commented on SB-27:
-------------------------------
Just a note. I think your implementation is still valid. After all the tag changes I wonder, though if the patch will apply correctly. The "page" attribute type is now "template" just for consistency with other tags. Other than that I think what you've done here is the right thing.
> tiles:insert tag does not try to guess the type of attribute
> ------------------------------------------------------------
>
> Key: SB-27
> URL: http://issues.apache.org/struts/browse/SB-27
> Project: Sandbox
> Issue Type: Bug
> Components: Tiles
> Affects Versions: 2.0
> Environment: Windows 2000 and Linux (Ubuntu Breezy), JDK 1.5.0_06, Tomcat 5.5.17
> Reporter: Antonio Petrelli
> Assigned To: Antonio Petrelli
> Priority: Minor
> Attachments: it_patch.diff
>
>
> The <tiles:insert> (i.e. its implementation InsertTag) does not try to guess the type of an attribute if the type is not specified.
> Therefore, if the type is not there, a null value is returned as the value of the attribute, so that nothing is displayed.
> I posted a patch to solve this issue, though I am not sure if "page" is a good type for an attribute that has the form "/somewhere/somewhat.jsp".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira