You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Hejki <gi...@git.apache.org> on 2016/04/07 13:25:04 UTC
[GitHub] nifi pull request: NIFI-1738 - Repair logger names for ControllerS...
GitHub user Hejki opened a pull request:
https://github.com/apache/nifi/pull/334
NIFI-1738 - Repair logger names for ControllerStatusReportingTask
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hejki/nifi nifi-1738
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #334
----
commit 4fd8ff38e81504b7060f80e8e156f618abb145a2
Author: Hejki <he...@me.com>
Date: 2016-04-07T11:20:26Z
NIFI-1738 - Repair logger names for ControllerStatusReportingTask
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1738 - Repair logger names for ControllerS...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/334#issuecomment-211080536
@Hejki please let us know if you are good with the tests from @jvwing , then we can amend your commit with @jvwing changes and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1738 - Repair logger names for ControllerS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1738 - Repair logger names for ControllerS...
Posted by Hejki <gi...@git.apache.org>.
Github user Hejki commented on the pull request:
https://github.com/apache/nifi/pull/334#issuecomment-211089956
I'm ok with @jvwing tests, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1738 - Repair logger names for ControllerS...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/334#issuecomment-211091503
Perfect, working on it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1738 - Repair logger names for ControllerS...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the pull request:
https://github.com/apache/nifi/pull/334#issuecomment-207841740
@Hejki, this looks like a solid fix to me. One thing I suggest you add is some unit tests, which I missed when I "fixed" this a couple months ago. If that sounds like overkill for such a simple change, well... I use to agree :).
I made some [sample tests to verify your fix](https://github.com/jvwing/nifi/commit/004ca21e50dd4f4c98923dbb9a49528ad8544179), you are welcome to use them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---