You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2018/01/27 16:36:00 UTC
[jira] [Commented] (KYLIN-3204) Potentially unclosed resources in
JdbcExplorer#evalQueryMetadata
[ https://issues.apache.org/jira/browse/KYLIN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342212#comment-16342212 ]
Ted Yu commented on KYLIN-3204:
-------------------------------
Modified the description.
The two highlighted calls should be placed in finally block.
> Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
> ----------------------------------------------------------------
>
> Key: KYLIN-3204
> URL: https://issues.apache.org/jira/browse/KYLIN-3204
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Major
>
> {code}
> Connection con = SqlUtil.getConnection(dbconf);
> DatabaseMetaData dbmd = con.getMetaData();
> ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
> {code}
> con and rs should be closed upon return even if there is exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)