[arrow] branch master updated: ARROW-2505: [C++] Disable MSVC warning C4800

[ap...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 6bf1c66  ARROW-2505: [C++] Disable MSVC warning C4800
6bf1c66 is described below

commit 6bf1c665ab5c20d0583643fc4f166a05ffee66e9
Author: Antoine Pitrou <an...@python.org>
AuthorDate: Wed May 2 12:02:33 2018 +0200

    ARROW-2505: [C++] Disable MSVC warning C4800
    
    Author: Antoine Pitrou <an...@python.org>
    
    Closes #1980 from pitrou/ARROW-2505-disable-msvc-warning-c4800 and squashes the following commits:
    
    f586da2 <Antoine Pitrou> Fix command-line option
    bb064db <Antoine Pitrou> ARROW-2505:  Disable MSVC warning C4800
---
 cpp/cmake_modules/SetupCxxFlags.cmake | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/cpp/cmake_modules/SetupCxxFlags.cmake b/cpp/cmake_modules/SetupCxxFlags.cmake
index 28d903f..6387cfc 100644
--- a/cpp/cmake_modules/SetupCxxFlags.cmake
+++ b/cpp/cmake_modules/SetupCxxFlags.cmake
@@ -167,6 +167,11 @@ else()
   endif()
 endif()
 
+# Disable annoying "performance warning" about int-to-bool conversion
+if ("${COMPILER_FAMILY}" STREQUAL "msvc")
+  set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} /wd4800")
+endif()
+
 # if build warning flags is set, add to CXX_COMMON_FLAGS
 if (BUILD_WARNING_FLAGS)
   # Use BUILD_WARNING_FLAGS with BUILD_WARNING_LEVEL=everything to disable

-- 
To stop receiving notification emails like this one, please contact
apitrou@apache.org.