You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/09 01:05:47 UTC

[GitHub] [arrow] domoritz opened a new pull request #10281: XXXX: [JS] Use closure for every target but es5

domoritz opened a new pull request #10281:
URL: https://github.com/apache/arrow/pull/10281


   This branch
   
   ```
   targets/es5/umd/:
   1.1M -I Arrow.es5.min.js.map
   218k -I Arrow.js
   
   targets/es2015/umd/:
   534k -I Arrow.es2015.min.js.map
    55k -I Arrow.externs.js
   180k -I Arrow.js
   
   targets/esnext/umd/:
   512k -I Arrow.esnext.min.js.map
    55k -I Arrow.externs.js
   172k -I Arrow.js
   ```
   
   Master
   
   ```
   targets/es5/umd/:
   694k -I Arrow.es5.min.js.map
    55k -I Arrow.externs.js
   253k -I Arrow.js
   
   targets/es2015/umd/:
   1.2M -I Arrow.es2015.min.js.map
   233k -I Arrow.js
   
   targets/esnext/umd/:
   1.1M -I Arrow.esnext.min.js.map
   225k -I Arrow.js
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] domoritz edited a comment on pull request #10281: ARROW-12393: [JS] Use closure for every target but es5

Posted by GitBox <gi...@apache.org>.
domoritz edited a comment on pull request #10281:
URL: https://github.com/apache/arrow/pull/10281#issuecomment-841689886


   Ahh, looks like the build system tricked me. 
   
   ```
   targets/es5/umd/:
      - -I bin
   1.2M -I Arrow.es5.min.js.map
   302k -I Arrow.js
   ```
   
   We should use closure for everything. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10281: XXXX: [JS] Use closure for every target but es5

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10281:
URL: https://github.com/apache/arrow/pull/10281#issuecomment-835607317


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] domoritz commented on pull request #10281: ARROW-12393: [JS] Use closure for every UMD target

Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #10281:
URL: https://github.com/apache/arrow/pull/10281#issuecomment-841690343


   https://github.com/apache/arrow/blob/068318fed5a2f3f77cf8cdd3ca2b0a86e0f8bace/js/tsconfig/tsconfig.es2015.cls.json#L1 is wrong then. We use the `.cls` config also for terser and not just closure. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] domoritz closed pull request #10281: ARROW-12393: [JS] Use closure compiler for all UMD targets

Posted by GitBox <gi...@apache.org>.
domoritz closed pull request #10281:
URL: https://github.com/apache/arrow/pull/10281


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10281: ARROW-12393: [JS] Use closure for every target but es5

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10281:
URL: https://github.com/apache/arrow/pull/10281#issuecomment-835607737


   https://issues.apache.org/jira/browse/ARROW-12393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] domoritz commented on pull request #10281: ARROW-12393: [JS] Use closure for all UMD targets

Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #10281:
URL: https://github.com/apache/arrow/pull/10281#issuecomment-841698642


   I updated the pull request to use closure for every target. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] domoritz commented on a change in pull request #10281: ARROW-12393: [JS] Use closure for every UMD target

Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10281:
URL: https://github.com/apache/arrow/pull/10281#discussion_r632983210



##########
File path: js/tsconfig/tsconfig.es2015.cls.json
##########
@@ -2,10 +2,10 @@
 {
   "extends": "./tsconfig.base.json",
   "compilerOptions": {
-    "target": "ES2015",

Review comment:
       Apparently the documentation for this file was incorrect. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] domoritz commented on a change in pull request #10281: ARROW-12393: [JS] Use closure for every target but es5

Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10281:
URL: https://github.com/apache/arrow/pull/10281#discussion_r632971808



##########
File path: js/tsconfig/tsconfig.es2015.cls.json
##########
@@ -2,10 +2,10 @@
 {
   "extends": "./tsconfig.base.json",
   "compilerOptions": {
-    "target": "ES2015",

Review comment:
       @trxcllnt why was this es2015? The output was always only used for closure so all `.cls.json` files should be identical, no?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] domoritz closed pull request #10281: ARROW-12393: [JS] Use closure compiler for all UMD targets

Posted by GitBox <gi...@apache.org>.
domoritz closed pull request #10281:
URL: https://github.com/apache/arrow/pull/10281


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] domoritz commented on pull request #10281: ARROW-12393: [JS] Use closure for every target but es5

Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #10281:
URL: https://github.com/apache/arrow/pull/10281#issuecomment-841689886


   Ahh, looks like the build system tricked me. 
   
   ```
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org