You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2023/01/12 10:43:41 UTC
[GitHub] [camel] orpiske opened a new pull request, #9059: (chores) camel 4: adjust the contribution template to help users identify the correct branch
orpiske opened a new pull request, #9059:
URL: https://github.com/apache/camel/pull/9059
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9059: (chores) camel 4: adjust the contribution template to help users identify the correct branch
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #9059:
URL: https://github.com/apache/camel/pull/9059#issuecomment-1380139143
Sounds good to me. We should harmonize the template even in the subprojects though. Not only for Camel 3/Camel 4, but in general
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #9059: (chores) camel 4: adjust the contribution template to help users identify the correct branch
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #9059:
URL: https://github.com/apache/camel/pull/9059#issuecomment-1380140773
> Sounds good to me. We should harmonize the template even in the subprojects though. Not only for Camel 3/Camel 4, but in general
Yeah. I've been thinking about cleaning up our contribution guides. Having a common template would make things easier too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #9059: (chores) camel 4: adjust the contribution template to help users identify the correct branch
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #9059:
URL: https://github.com/apache/camel/pull/9059#issuecomment-1380138057
I adjusted the template to take into consideration Camel 3 and Camel 4.
@oscerd / @davsclaus should we keep this templated enabled by default during Camel 4 development? Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #9059: (chores) camel 4: adjust the contribution template to help users identify the correct branch
Posted by GitBox <gi...@apache.org>.
orpiske merged PR #9059:
URL: https://github.com/apache/camel/pull/9059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org