You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/01/14 13:13:23 UTC
[GitHub] [incubator-livy] codecov-io edited a comment on issue #249:
[LIVY-702]: Submit Spark apps to Kubernetes
codecov-io edited a comment on issue #249: [LIVY-702]: Submit Spark apps to Kubernetes
URL: https://github.com/apache/incubator-livy/pull/249#issuecomment-546723412
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=h1) Report
> Merging [#249](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/66b5833e413bc10e39e3b92b585f496444c147d4?src=pr&el=desc) will **decrease** coverage by `1.63%`.
> The diff coverage is `34.53%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #249 +/- ##
============================================
- Coverage 68.14% 66.51% -1.64%
- Complexity 959 977 +18
============================================
Files 104 105 +1
Lines 5946 6247 +301
Branches 899 954 +55
============================================
+ Hits 4052 4155 +103
- Misses 1312 1488 +176
- Partials 582 604 +22
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.16% <0%> (+0.16%)` | `45 <0> (ø)` | :arrow_down: |
| [...e/livy/server/interactive/InteractiveSession.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uLnNjYWxh) | `69.56% <0%> (-0.62%)` | `51 <0> (ø)` | |
| [rsc/src/main/java/org/apache/livy/rsc/RSCConf.java](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDb25mLmphdmE=) | `88.18% <100%> (+0.33%)` | `9 <1> (+1)` | :arrow_up: |
| [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.42% <100%> (+0.29%)` | `23 <2> (+2)` | :arrow_up: |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `33.03% <20%> (-0.45%)` | `11 <1> (ø)` | |
| [...ala/org/apache/livy/utils/SparkKubernetesApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya0t1YmVybmV0ZXNBcHAuc2NhbGE=) | `32.42% <32.42%> (ø)` | `14 <14> (?)` | |
| [...rc/main/scala/org/apache/livy/utils/SparkApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya0FwcC5zY2FsYQ==) | `45.23% <5.55%> (-30.77%)` | `1 <0> (ø)` | |
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `52.94% <0%> (-2.95%)` | `7% <0%> (ø)` | |
| [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `30.76% <0%> (-2.57%)` | `7% <0%> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=footer). Last update [66b5833...4a6501c](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services