You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Kevin Clark (JIRA)" <ji...@apache.org> on 2008/11/11 06:39:44 UTC

[jira] Created: (THRIFT-196) Specs should regenerate fixture code

Specs should regenerate fixture code
------------------------------------

                 Key: THRIFT-196
                 URL: https://issues.apache.org/jira/browse/THRIFT-196
             Project: Thrift
          Issue Type: Bug
          Components: Library (Ruby)
            Reporter: Kevin Clark




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (THRIFT-196) Specs should regenerate fixture code

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury reassigned THRIFT-196:
------------------------------------

    Assignee: Kevin Clark

> Specs should regenerate fixture code
> ------------------------------------
>
>                 Key: THRIFT-196
>                 URL: https://issues.apache.org/jira/browse/THRIFT-196
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Kevin Clark
>            Assignee: Kevin Clark
>         Attachments: 0001-rb-Specs-should-regenerate-fixture-code-THRIFT-196.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-196) Specs should regenerate fixture code

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647661#action_12647661 ] 

Kevin Clark commented on THRIFT-196:
------------------------------------

Mmmaybe. I guess one situation where that wouldn't work is if someone who didn't have the tools to compile a thrift binary was working on the lib, and needed the fixtures. But that seems a little silly.

> Specs should regenerate fixture code
> ------------------------------------
>
>                 Key: THRIFT-196
>                 URL: https://issues.apache.org/jira/browse/THRIFT-196
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Kevin Clark
>         Attachments: 0001-rb-Specs-should-regenerate-fixture-code-THRIFT-196.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-196) Specs should regenerate fixture code

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Clark updated THRIFT-196:
-------------------------------

    Attachment: 0001-rb-Specs-should-regenerate-fixture-code-THRIFT-196.patch

Adds a dep to the default rake task

> Specs should regenerate fixture code
> ------------------------------------
>
>                 Key: THRIFT-196
>                 URL: https://issues.apache.org/jira/browse/THRIFT-196
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Kevin Clark
>         Attachments: 0001-rb-Specs-should-regenerate-fixture-code-THRIFT-196.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-196) Specs should regenerate fixture code

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646484#action_12646484 ] 

Bryan Duxbury commented on THRIFT-196:
--------------------------------------

Wondering, if the code is automatically regenerated during the tests, should we just remove the generated code from subversion? 

> Specs should regenerate fixture code
> ------------------------------------
>
>                 Key: THRIFT-196
>                 URL: https://issues.apache.org/jira/browse/THRIFT-196
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Kevin Clark
>         Attachments: 0001-rb-Specs-should-regenerate-fixture-code-THRIFT-196.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (THRIFT-196) Specs should regenerate fixture code

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Clark closed THRIFT-196.
------------------------------

    Resolution: Fixed

In 714070.

> Specs should regenerate fixture code
> ------------------------------------
>
>                 Key: THRIFT-196
>                 URL: https://issues.apache.org/jira/browse/THRIFT-196
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Kevin Clark
>         Attachments: 0001-rb-Specs-should-regenerate-fixture-code-THRIFT-196.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-196) Specs should regenerate fixture code

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646481#action_12646481 ] 

Bryan Duxbury commented on THRIFT-196:
--------------------------------------

I like it. This will make it a lot harder to miss changes to the code generator. +1

> Specs should regenerate fixture code
> ------------------------------------
>
>                 Key: THRIFT-196
>                 URL: https://issues.apache.org/jira/browse/THRIFT-196
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Kevin Clark
>         Attachments: 0001-rb-Specs-should-regenerate-fixture-code-THRIFT-196.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.