[jira] [Resolved] (CALCITE-3389) Test can fail if HashSet iterates in a different order

["Haisheng Yuan (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Haisheng Yuan resolved CALCITE-3389.
------------------------------------
    Fix Version/s: 1.22.0
       Resolution: Fixed

Fixed in https://github.com/apache/calcite/commit/abf36e4da4884f2c22435384aa55d68f968a784e, thanks for the PR, [~contextshuffling]!

> Test can fail if HashSet iterates in a different order
> ------------------------------------------------------
>
>                 Key: CALCITE-3389
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3389
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: contextshuffling
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> For test `testTenElementsSetLiteral`([https://github.com/apache/calcite/blob/78c2a007b5b597f673323b80dde21c23d31f23ea/linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java#L1538) |https://github.com/apache/calcite/blob/78c2a007b5b597f673323b80dde21c23d31f23ea/linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java#L1538)]
> It relies on the iteration order of a HashSet. However, HashSet does not guarantee any specific order of entries. Tests can fail if the iteration order changes.
> Please let me know if you want to discuss the changes more.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)