You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/30 08:26:56 UTC

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #6521: add insert select and replace select statement doc

strongduanmu commented on a change in pull request #6521:
URL: https://github.com/apache/shardingsphere/pull/6521#discussion_r462817780



##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -117,7 +119,8 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
 | SQL                                                                                        | 不支持原因                  |
 | ------------------------------------------------------------------------------------------ | -------------------------- |
 | INSERT INTO tbl_name (col1, col2, ...) VALUES(1+2, ?, ...)                                 | VALUES语句不支持运算表达式   |
-| INSERT INTO tbl_name (col1, col2, ...) SELECT col1, col2, ... FROM tbl_name WHERE col3 = ? | INSERT .. SELECT           |
+| INSERT INTO tbl_name (col1, col2, ...) SELECT * FROM tbl_name WHERE col3 = ?               | SELECT子句暂不支持*号简写,暂不支持使用内置的分布式主键生成器 |

Review comment:
       > SELECT子句暂不支持_号简写;暂不支持使用内置的分布式主键生成器 或者 SELECT子句暂不支持_号简写及使用内置的分布式主键生成器
   
   @tristaZero I think the first statement may be better. I will fix it. 😀

##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -117,7 +119,8 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
 | SQL                                                                                        | 不支持原因                  |
 | ------------------------------------------------------------------------------------------ | -------------------------- |
 | INSERT INTO tbl_name (col1, col2, ...) VALUES(1+2, ?, ...)                                 | VALUES语句不支持运算表达式   |
-| INSERT INTO tbl_name (col1, col2, ...) SELECT col1, col2, ... FROM tbl_name WHERE col3 = ? | INSERT .. SELECT           |
+| INSERT INTO tbl_name (col1, col2, ...) SELECT * FROM tbl_name WHERE col3 = ?               | SELECT子句暂不支持*号简写,暂不支持使用内置的分布式主键生成器 |

Review comment:
       Maybe `SELECT子句暂不支持使用*号简写及内置的分布式主键生成器` is better. 😂




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org