You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by GitBox <gi...@apache.org> on 2020/10/11 04:34:33 UTC
[GitHub] [yetus] aw-was-here opened a new pull request #156: YETUS-1022. Get commit sha from github PR json
aw-was-here opened a new pull request #156:
URL: https://github.com/apache/yetus/pull/156
* includes some docs updates to reflect
what is supported for github
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aajisaka commented on pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #156:
URL: https://github.com/apache/yetus/pull/156#issuecomment-707181058
Thank you @aw-was-here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here merged pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aw-was-here merged pull request #156:
URL: https://github.com/apache/yetus/pull/156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #156:
URL: https://github.com/apache/yetus/pull/156#issuecomment-707087602
Argh. Need to rebase to pick up #154's website checker action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #156:
URL: https://github.com/apache/yetus/pull/156#issuecomment-707101643
Thanks for the review. website changes passed, so I'm merging this in....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aajisaka commented on pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #156:
URL: https://github.com/apache/yetus/pull/156#issuecomment-706953348
Thank you @aw-was-here
I'm testing the PR in https://github.com/apache/hadoop/pull/2348
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aajisaka commented on pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #156:
URL: https://github.com/apache/yetus/pull/156#issuecomment-707092342
(This is not directly related to this issue)
Now the "Details" link is [console](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2348/12/console).
I think it's better for developers to link to the report HTML (ex. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2348/12/Yetus_20Report/) instead of the console. It can be discussed/implemented in a separate issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #156:
URL: https://github.com/apache/yetus/pull/156#issuecomment-707091766
Thanks @aajisaka! Now I just need to make sure the website bits are correct ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #156:
URL: https://github.com/apache/yetus/pull/156#issuecomment-707093523
> (This is not directly related to this issue)
>
> Now the "Details" link is [console](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2348/12/console).
> I think it's better for developers to link to the report HTML (ex. [ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2348/12/Yetus_20Report](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2348/12/Yetus_20Report/)) instead of the console. It can be discussed/implemented in a separate issue.
It definitely needs to be a separare issue since it means mixing two separate plug-ins. There's no guarantee that htmlout's output is actually reachable either... for example, on here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aw-was-here commented on pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #156:
URL: https://github.com/apache/yetus/pull/156#issuecomment-706654214
FYI: I don't want to commit this until YETUS-1021 gets in so that it can validate the website changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus] aajisaka commented on pull request #156: YETUS-1022. Get commit sha from github PR json
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #156:
URL: https://github.com/apache/yetus/pull/156#issuecomment-707089086
The commit status is updated successfully in https://github.com/apache/hadoop/pull/2348
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org