You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Markus Hoffrogge (Jira)" <ji...@apache.org> on 2025/03/31 23:21:00 UTC

[jira] [Created] (SCM-1029) JGit performing empty commits on CheckIn command if includes or excludes fileset is defined but no files changed in it

Markus Hoffrogge created SCM-1029:
-------------------------------------

             Summary: JGit performing empty commits on CheckIn command if includes or excludes fileset is defined but no files changed in it
                 Key: SCM-1029
                 URL: https://issues.apache.org/jira/browse/SCM-1029
             Project: Maven SCM
          Issue Type: Bug
          Components: maven-scm-provider-jgit
    Affects Versions: 2.1.0
            Reporter: Markus Hoffrogge


*Issue*

If includes and/or excludes config is defined, then JGit checkIn is performing empty commits if no changes are applied to the effective fileset content BUT other files are changed that are NOT within the effective scope of the includes or excludes related fileset.



*Root cause*

Method *JGitCheckInCommand.executeCheckInCommand* is using git.status().call().{*}hasUncommittedChanges(){*} if there is nothing to commit returned by *JGitUtils.addAllFiles(git, fileSet).*
 ** Since git.status().call().{*}hasUncommittedChanges(){*} returns the state of any file within the working tree of the repo, this will set *doCommit* true even in case there is no file changed or added in scope of the includes / excludes effective fileset.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)