You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "jaak-pruulmann-sympower (via GitHub)" <gi...@apache.org> on 2024/04/02 11:48:29 UTC

Re: [PR] [improve] [broker] Do not print an Error log when responding to `HTTP-404` when calling `Admin API` and the topic does not exist. [pulsar]

jaak-pruulmann-sympower commented on code in PR #21995:
URL: https://github.com/apache/pulsar/pull/21995#discussion_r1547715095


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/NonPersistentTopics.java:
##########
@@ -132,7 +132,7 @@ public void getInternalStats(
                 })
                 .thenAccept(asyncResponse::resume)
                 .exceptionally(ex -> {
-                    if (!isRedirectException(ex)) {
+                    if (!isNot307And404Exception(ex)) {

Review Comment:
   Looks like this line and all the others where `!isRedirectException(ex)` has been replaced with `!isNot307..` are wrong, as the new line should NOT have the negation exclamation mark any more. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org