You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2016/01/11 16:03:16 UTC
Re: Review Request 42140: Removed deprecated constructor of
http::Unauthorized in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 4:03 p.m.)
Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.
Changes
-------
Changes after Benjamin's review.
Summary (updated)
-----------------
Removed deprecated constructor of http::Unauthorized in libprocess.
Bugs: MESOS-3933 and MESOS-4305
https://issues.apache.org/jira/browse/MESOS-3933
https://issues.apache.org/jira/browse/MESOS-4305
Repository: mesos
Description (updated)
-------
The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase.
This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.
Diffs (updated)
-----
src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc
src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a
src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae
Diff: https://reviews.apache.org/r/42140/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 42140: Removed deprecated constructor of
http::Unauthorized in libprocess.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/#review113762
-----------------------------------------------------------
Ship it!
src/tests/teardown_tests.cpp (line 18)
<https://reviews.apache.org/r/42140/#comment174566>
Not needded anymore, just like `string`; could you remove both?
src/tests/teardown_tests.cpp (line 41)
<https://reviews.apache.org/r/42140/#comment174567>
Not needded anymore, just like `string`; could you remove both?
- Benjamin Bannier
On Jan. 11, 2016, 4:03 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42140/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 4:03 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3933 and MESOS-4305
> https://issues.apache.org/jira/browse/MESOS-3933
> https://issues.apache.org/jira/browse/MESOS-4305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase.
>
> This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.
>
>
> Diffs
> -----
>
> src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc
> src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a
> src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
> src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
> src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae
>
> Diff: https://reviews.apache.org/r/42140/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 42140: Removed deprecated constructor of
http::Unauthorized in libprocess.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/#review113775
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Jan. 11, 2016, 4:41 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42140/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 4:41 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3933 and MESOS-4305
> https://issues.apache.org/jira/browse/MESOS-3933
> https://issues.apache.org/jira/browse/MESOS-4305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase.
>
> This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.
>
>
> Diffs
> -----
>
> src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc
> src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a
> src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
> src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
> src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae
>
> Diff: https://reviews.apache.org/r/42140/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 42140: Removed deprecated constructor of
http::Unauthorized in libprocess.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/#review113823
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40539, 37999, 38000, 38094, 38950, 39043, 42027, 42143, 42144, 42140]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 11, 2016, 3:41 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42140/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 3:41 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3933 and MESOS-4305
> https://issues.apache.org/jira/browse/MESOS-3933
> https://issues.apache.org/jira/browse/MESOS-4305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase.
>
> This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.
>
>
> Diffs
> -----
>
> src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc
> src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a
> src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
> src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
> src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae
>
> Diff: https://reviews.apache.org/r/42140/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 42140: Removed deprecated constructor of
http::Unauthorized in Mesos.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/#review115432
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 18, 2016, 10:53 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42140/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 10:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3933 and MESOS-4305
> https://issues.apache.org/jira/browse/MESOS-3933
> https://issues.apache.org/jira/browse/MESOS-4305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase.
>
> This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.
>
>
> Diffs
> -----
>
> src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc
> src/tests/master_quota_tests.cpp e8cb074c2913cafdc6b1792896f29e53f1210c9d
> src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
> src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
> src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae
>
> Diff: https://reviews.apache.org/r/42140/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 42140: Removed deprecated constructor of
http::Unauthorized in Mesos.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/#review115001
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40539, 37999, 38000, 38094, 38950, 39043, 42027, 42143, 42144, 42140]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 18, 2016, 10:53 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42140/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 10:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3933 and MESOS-4305
> https://issues.apache.org/jira/browse/MESOS-3933
> https://issues.apache.org/jira/browse/MESOS-4305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase.
>
> This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.
>
>
> Diffs
> -----
>
> src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc
> src/tests/master_quota_tests.cpp e8cb074c2913cafdc6b1792896f29e53f1210c9d
> src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
> src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
> src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae
>
> Diff: https://reviews.apache.org/r/42140/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 42140: Removed deprecated constructor of
http::Unauthorized in Mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 11:53 a.m.)
Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.
Changes
-------
Rebase.
Bugs: MESOS-3933 and MESOS-4305
https://issues.apache.org/jira/browse/MESOS-3933
https://issues.apache.org/jira/browse/MESOS-4305
Repository: mesos
Description
-------
The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase.
This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.
Diffs (updated)
-----
src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc
src/tests/master_quota_tests.cpp e8cb074c2913cafdc6b1792896f29e53f1210c9d
src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae
Diff: https://reviews.apache.org/r/42140/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 42140: Removed deprecated constructor of
http::Unauthorized in Mesos.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 11:38 a.m.)
Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.
Summary (updated)
-----------------
Removed deprecated constructor of http::Unauthorized in Mesos.
Bugs: MESOS-3933 and MESOS-4305
https://issues.apache.org/jira/browse/MESOS-3933
https://issues.apache.org/jira/browse/MESOS-4305
Repository: mesos
Description
-------
The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase.
This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.
Diffs
-----
src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc
src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a
src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae
Diff: https://reviews.apache.org/r/42140/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 42140: Removed deprecated constructor of
http::Unauthorized in libprocess.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 4:41 p.m.)
Review request for mesos, Benjamin Bannier, Ben Mahler, Jan Schlicht, and Till Toenshoff.
Changes
-------
Benjamin's review.
Bugs: MESOS-3933 and MESOS-4305
https://issues.apache.org/jira/browse/MESOS-3933
https://issues.apache.org/jira/browse/MESOS-4305
Repository: mesos
Description
-------
The constructor of `process::http::Unauthorized(const std::string&)` is marked as deprecated. This patch fully removes the constructor and cleans up its usage in the Mesos codebase.
This change also allows to use initializer lists on the `process::http::Unauthorized(const std::vector<std::string>&)` constructor since there is no longer an ambiguity.
Diffs (updated)
-----
src/tests/http_authentication_tests.cpp 3d6da53b8d6b4f0d3e5631a1855983583c0ae7dc
src/tests/master_quota_tests.cpp 776a168254af6fa8a5d87d4580b35d83f2d5909a
src/tests/persistent_volume_endpoints_tests.cpp f0cce190abc90f0fae84d6c3db20e8215c2d8132
src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae
Diff: https://reviews.apache.org/r/42140/diff/
Testing
-------
make check
Thanks,
Alexander Rojas