You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2022/07/03 11:13:42 UTC

[commons-crypto] branch master updated: argLine was a red herring

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git


The following commit(s) were added to refs/heads/master by this push:
     new 4e562be  argLine was a red herring
4e562be is described below

commit 4e562bea2024d082b9a309be90a2441d955430db
Author: Sebb <se...@apache.org>
AuthorDate: Sun Jul 3 12:13:33 2022 +0100

    argLine was a red herring
    
    Also run sample tests individidually
---
 .github/workflows/maven.yml | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 0263f25..c118a22 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -62,11 +62,6 @@ jobs:
         java-version: ${{ matrix.java }}
     - name: OpenSSL version
       run: openssl version
-    - name: Set argline
-      run: echo $argLine
-      env:
-        argLine: -DargLine="--illegal-access=deny"
-      if: ${{ matrix.java != '8' }}
     - name: Build with Maven
       # OPENSSL_HOME is needed for Windows build; not used by other builds so can set unconditionally
       # It's not clear how one is supposed to find the correct setting;
@@ -76,9 +71,11 @@ jobs:
       # "C:\\ProgramData\\chocolatey\\lib\\mingw\\tools\\install\\mingw64\\opt"
       env:
         OPENSSL_HOME: "C:\\Miniconda\\Library"
-      # Temporarily add  -DargLine="--illegal-access=deny" to avoid native output crash
-      run: mvn -V --file pom.xml --no-transfer-progress -DtrimStackTrace=false $argLine
-    - name: Run sample programs
+      run: mvn -V --file pom.xml --no-transfer-progress -DtrimStackTrace=false
+    - name: Run Crypto (JNI)
       run: |
         mvn -q exec:java -D"exec.mainClass=org.apache.commons.crypto.Crypto"
+    - name: Run OpenSslJna (JNA)
+      if: always()
+      run: |
         mvn -q exec:java -D"exec.mainClass=org.apache.commons.crypto.jna.OpenSslJna"