You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/25 10:17:18 UTC
[GitHub] [spark] beliefer commented on a change in pull request #31619: [WIP][SPARK-33600] Group exception messages in execution/datasources/v2
beliefer commented on a change in pull request #31619:
URL: https://github.com/apache/spark/pull/31619#discussion_r582707844
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala
##########
@@ -83,7 +84,7 @@ private class PartitionIterator[T](reader: PartitionReader[T]) extends Iterator[
override def next(): T = {
if (!hasNext) {
- throw new java.util.NoSuchElementException("End of stream")
+ throw QueryExecutionErrors.endOfStreamError()
Review comment:
`NoSuchElementException` is generated during execute and should be placed in `QueryExecutionErrors`.
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSessionCatalogSuite.scala
##########
@@ -125,7 +126,7 @@ class InMemoryTableSessionCatalog extends TestV2SessionCatalogBase[InMemoryTable
newTable
case _ =>
- throw new NoSuchTableException(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ReplaceTableExec.scala
##########
@@ -74,10 +75,10 @@ case class AtomicReplaceTableExec(
identifier, tableSchema, partitioning.toArray, tableProperties.asJava)
} catch {
case e: NoSuchTableException =>
- throw new CannotReplaceMissingTableException(identifier, Some(e))
+ throw QueryCompilationErrors.cannotReplaceMissingTableError(identifier, Some(e))
}
} else {
- throw new CannotReplaceMissingTableException(identifier)
+ throw QueryCompilationErrors.cannotReplaceMissingTableError(identifier)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -215,7 +215,7 @@ class V2SessionCatalog(catalog: SessionCatalog)
case Array(db) if catalog.databaseExists(db) =>
Array()
case _ =>
- throw new NoSuchNamespaceException(namespace)
+ throw QueryCompilationErrors.noSuchNamespaceError(namespace)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -109,7 +109,7 @@ case class AtomicCreateTableAsSelectExec(
return Nil
}
- throw new TableAlreadyExistsException(ident)
+ throw QueryCompilationErrors.tableAlreadyExistsError(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropNamespaceExec.scala
##########
@@ -43,17 +42,15 @@ case class DropNamespaceExec(
if (!cascade) {
if (catalog.asTableCatalog.listTables(ns).nonEmpty
|| nsCatalog.listNamespaces(ns).nonEmpty) {
- throw new SparkException(
- s"Cannot drop a non-empty namespace: ${namespace.quoted}. " +
- "Use CASCADE option to drop a non-empty namespace.")
+ throw QueryExecutionErrors.cannotDropNonemptyNamespaceError(namespace)
}
}
if (!nsCatalog.dropNamespace(ns)) {
- throw new SparkException(s"Failed to drop a namespace: ${namespace.quoted}.")
+ throw QueryExecutionErrors.cannotDropNonemptyNamespaceError(namespace)
}
} else if (!ifExists) {
- throw new NoSuchNamespaceException(ns)
+ throw QueryCompilationErrors.noSuchNamespaceError(ns)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropTableExec.scala
##########
@@ -37,7 +37,7 @@ case class DropTableExec(
invalidateCache()
if (purge) catalog.purgeTable(ident) else catalog.dropTable(ident)
} else if (!ifExists) {
- throw new NoSuchTableException(ident)
+ throw QueryCompilationErrors.noSuchTableError(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ReplaceTableExec.scala
##########
@@ -74,10 +75,10 @@ case class AtomicReplaceTableExec(
identifier, tableSchema, partitioning.toArray, tableProperties.asJava)
} catch {
case e: NoSuchTableException =>
- throw new CannotReplaceMissingTableException(identifier, Some(e))
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -65,7 +66,7 @@ class V2SessionCatalog(catalog: SessionCatalog)
catalog.getTableMetadata(ident.asTableIdentifier)
} catch {
case _: NoSuchTableException =>
- throw new NoSuchTableException(ident)
+ throw QueryCompilationErrors.noSuchTableError(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -150,7 +151,7 @@ class V2SessionCatalog(catalog: SessionCatalog)
storage = storage))
} catch {
case _: NoSuchTableException =>
- throw new NoSuchTableException(ident)
+ throw QueryCompilationErrors.noSuchTableError(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -110,7 +111,7 @@ class V2SessionCatalog(catalog: SessionCatalog)
catalog.createTable(tableDesc, ignoreIfExists = false)
} catch {
case _: TableAlreadyExistsException =>
- throw new TableAlreadyExistsException(ident)
+ throw QueryCompilationErrors.tableAlreadyExistsError(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -129,7 +130,7 @@ class V2SessionCatalog(catalog: SessionCatalog)
catalog.getTableMetadata(ident.asTableIdentifier)
} catch {
case _: NoSuchTableException =>
- throw new NoSuchTableException(ident)
+ throw QueryCompilationErrors.noSuchTableError(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -56,7 +57,7 @@ class V2SessionCatalog(catalog: SessionCatalog)
.map(ident => Identifier.of(Array(ident.database.getOrElse("")), ident.table))
.toArray
case _ =>
- throw new NoSuchNamespaceException(namespace)
+ throw QueryCompilationErrors.noSuchNamespaceError(namespace)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -191,8 +192,7 @@ class V2SessionCatalog(catalog: SessionCatalog)
case Array(db) =>
TableIdentifier(ident.name, Some(db))
case _ =>
- throw new NoSuchTableException(
- s"V2 session catalog requires a single-part namespace: ${ident.quoted}")
+ throw QueryCompilationErrors.requiresSinglePartNamespaceError(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -225,7 +225,7 @@ class V2SessionCatalog(catalog: SessionCatalog)
catalog.getDatabaseMetadata(db).toMetadata
case _ =>
- throw new NoSuchNamespaceException(namespace)
+ throw QueryCompilationErrors.noSuchNamespaceError(namespace)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -278,7 +277,7 @@ class V2SessionCatalog(catalog: SessionCatalog)
false
case _ =>
- throw new NoSuchNamespaceException(namespace)
+ throw QueryCompilationErrors.noSuchNamespaceError(namespace)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -74,7 +74,7 @@ case class CreateTableAsSelectExec(
return Nil
}
- throw new TableAlreadyExistsException(ident)
+ throw QueryCompilationErrors.tableAlreadyExistsError(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -200,10 +200,10 @@ case class AtomicReplaceTableAsSelectExec(
ident, schema, partitioning.toArray, properties.asJava)
} catch {
case e: NoSuchTableException =>
- throw new CannotReplaceMissingTableException(ident, Some(e))
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -153,7 +153,7 @@ case class ReplaceTableAsSelectExec(
invalidateCache(catalog, table, ident)
catalog.dropTable(ident)
} else if (!orCreate) {
- throw new CannotReplaceMissingTableException(ident)
Review comment:
ditto
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -261,14 +260,14 @@ class V2SessionCatalog(catalog: SessionCatalog)
toCatalogDatabase(db, CatalogV2Util.applyNamespaceChanges(metadata, changes)))
case _ =>
- throw new NoSuchNamespaceException(namespace)
+ throw QueryCompilationErrors.noSuchNamespaceError(namespace)
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org