You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/25 02:34:42 UTC
[GitHub] [flink] luoyuxia opened a new pull request, #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
luoyuxia opened a new pull request, #20071:
URL: https://github.com/apache/flink/pull/20071
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
To fix the exception "no any field presented in group by" when over window contains grouping function in Hive dialect like
`SELECT grouping(category), lag(live) over(partition by grouping(category)) FROM t GROUP BY category, live`
## Brief change log
- Not to rewrite group function again when it has been rewritten. The main changes logic is from [HIVE-15996](https://issues.apache.org/jira/browse/HIVE-15996)
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
Added test in [HiveDialectQueryITCase.java](https://github.com/apache/flink/compare/master...luoyuxia:FLINK-28247?expand=1#diff-fb5fc4106e27e27f9968e59b643003444fd40af58aa2f147ac301009b53a47ca)#testWindowWithGrouping
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1166200797
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1169738130
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1166175230
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3d0524f6fecebb340698defc6310ed23652f33c3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d0524f6fecebb340698defc6310ed23652f33c3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d0524f6fecebb340698defc6310ed23652f33c3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1175756612
I don't think the e2e test failure is related but I guess we need a green run to merge. @luoyuxia could you post your own CI result if it's successful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1172211963
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1168484528
@lirui-apache Thanks for reminder. I add a test for it to make sure this changes won't break such case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1175868034
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1168214812
Thanks @luoyuxia for fixing the issue. Should we also add test cases for grouping function with multiple parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1175903401
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache closed pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
lirui-apache closed pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
URL: https://github.com/apache/flink/pull/20071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #20071: [FLINK-28247][hive] fix "no any field presented in group by" exception when over window contains grouping function in Hive dialect
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #20071:
URL: https://github.com/apache/flink/pull/20071#issuecomment-1176948801
@lirui-apache The CI is passed now~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org