[GitHub] marcaurele commented on a change in pull request #2595: CLOUDSTACK-10199: Support requesting a specific IPv4 address

[GitBox <gi...@apache.org>]

marcaurele commented on a change in pull request #2595: CLOUDSTACK-10199: Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r183615227
 
 

 ##########
 File path: engine/schema/src/main/java/com/cloud/dc/dao/VlanDaoImpl.java
 ##########
 @@ -81,6 +81,22 @@ public VlanVO findByZoneAndVlanId(long zoneId, String vlanId) {
         sc.setParameters("vlanId", vlanId);
         return findOneBy(sc);
     }
+    
+    /**
+     * Returns a vlan by the network id.
+     */
+    @Override
+    public VlanVO findByNetworkId(long networkId) {
+        List<VlanVO> vlanVoList = listVlansByNetworkId(networkId);
+        VlanVO vlanVo = null;
+        for (VlanVO vlan : vlanVoList) {
+            if (vlan.getRemoved() == null) {
 
 Review comment:
   `listVlansByNetworkId` won't return removed entry since it's using the normal DAO `listBy()`.
   Another question: why picking the first one when the result could return many?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services