[GitHub] [airflow] ferruzzi commented on a diff in pull request #26652: Add GlacierUploadArchiveOperator

[GitBox <gi...@apache.org>]

ferruzzi commented on code in PR #26652:
URL: https://github.com/apache/airflow/pull/26652#discussion_r999679476


##########
airflow/providers/amazon/aws/operators/glacier.py:
##########
@@ -54,3 +54,55 @@ def __init__(
     def execute(self, context: Context):
         hook = GlacierHook(aws_conn_id=self.aws_conn_id)
         return hook.retrieve_inventory(vault_name=self.vault_name)
+
+
+class GlacierUploadArchiveOperator(BaseOperator):
+    """
+    This operation adds an archive to a vault
+
+    .. seealso::
+        For more information on how to use this operator, take a look at the guide:
+        :ref:`howto/operator:GlacierUploadArchiveOperator`
+
+    :param account_id: The AWS account ID of the account that owns the vault.
+        You can either specify an AWS account ID or optionally a single `-` (hyphen),
+        in which case Amazon S3 Glacier uses the AWS account ID associated with
+        the credentials used to sign the request
+    :param vault_name: The name of the vault
+    :param archive: A bytes or seekable file-like object. The data to upload.
+    :param description: The description of the archive you are uploading

Review Comment:
   I don't usually like to chime in with "me too", but I do the same.  I keep the names the same whenever possible to make it easier for folks who are used to using boto directly.  So I guess we're going from "personal opinion" to "unwritten rule" here.
   
   That said, I do see why these were changed, those were some misleading names and the new ones do make sense.  I could see making an exception to the "rule" here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org