You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/04/06 20:14:59 UTC
[GitHub] [cassandra] maedhroz commented on a diff in pull request #1432: CASSANDRA-17332 Add support for vnodes in jvm-dtest
maedhroz commented on code in PR #1432:
URL: https://github.com/apache/cassandra/pull/1432#discussion_r844369424
##########
test/distributed/org/apache/cassandra/distributed/test/ReplicaFilteringProtectionTest.java:
##########
@@ -50,30 +52,43 @@
private static final int ROWS = 3;
private static Cluster cluster;
+ private static String skipMessage;
@BeforeClass
public static void setup() throws IOException
{
- cluster = init(Cluster.build()
- .withNodes(REPLICAS)
- .withConfig(config -> config.set("hinted_handoff_enabled", false)
- .set("commitlog_sync", "batch")
- .set("num_tokens", 1)).start());
-
- // Make sure we start w/ the correct defaults:
- cluster.get(1).runOnInstance(() -> assertEquals(DEFAULT_WARN_THRESHOLD, StorageService.instance.getCachedReplicaRowsWarnThreshold()));
- cluster.get(1).runOnInstance(() -> assertEquals(DEFAULT_FAIL_THRESHOLD, StorageService.instance.getCachedReplicaRowsFailThreshold()));
+ try
+ {
+ cluster = init(Cluster.build()
+ .withNodes(REPLICAS)
+ .withConfig(config -> config.set("hinted_handoff_enabled", false)
+ .set("commitlog_sync", "batch")
+ .set("num_tokens", 1)).start());
Review Comment:
I think this was just a case of me explicitly simplifying the state of the test. There are only two nodes in this cluster, and it should work just fine with or without vnodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org