You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/03/17 00:54:15 UTC

[GitHub] [cordova-plugin-camera] hazems opened a new pull request #432: GH-420 (all) DATA_URL is improperly prefixed

hazems opened a new pull request #432: GH-420 (all) DATA_URL is improperly prefixed
URL: https://github.com/apache/cordova-plugin-camera/pull/432
 
 
   ### Platforms affected
   All (Android, iOS, OS X, Windows and Browser)
   
   
   ### Motivation and Context
   When calling `navigator.camera.getPicture` with `destinationType` set to `Camera.DestinationType.DATA_URL`, the success function is called with the base64 encoded data while it should has suitable data URL format on the following form:
   `data:[<mediatype>][;base64],<data>`
   
   It is an old issue in the library and it was previously reported under:
   https://issues.apache.org/jira/browse/CB-9819 
   
   And recently, it was also reported by one of the library users:
   https://github.com/apache/cordova-plugin-camera/issues/420
   
   ### Description
   I have implemented and tested the DATA_URL fix across all of the Camera plugin supported platforms:
   1. Android (Java)
   2. iOS (Objective C)
   3. OS X (Objective C)
   4. Browser (JavaScript)
   5. Windows Platform (JavaScript)
   
   ### Testing
   I manually tested this change across all of these platforms and they work fine.
   
   ### Checklist
   - [x] I've run the tests to see all new and existing tests pass
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org