You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by smola <gi...@git.apache.org> on 2015/04/12 18:41:41 UTC
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
GitHub user smola opened a pull request:
https://github.com/apache/spark/pull/5483
[SPARK-6874][SQL] Support standard SQL syntax for array declaration.
E.g. BIGINT ARRAY[1000]
More info:
- http://savage.net.au/SQL/sql-2003-2.bnf.html#array%20type
- http://www.postgresql.org/docs/devel/static/arrays.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smola/spark feature/sql-arrays
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5483
----
commit fca4e4b2dcb42452a665df4e3ee1e616bb7b5db5
Author: Santiago M. Mola <sa...@sap.com>
Date: 2015-04-11T17:45:35Z
[SPARK-6874][SQL] Support standard SQL syntax for array declaration.
E.g. BIGINT ARRAY[1000]
More info:
- http://savage.net.au/SQL/sql-2003-2.bnf.html#array%20type
- http://www.postgresql.org/docs/devel/static/arrays.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5483#issuecomment-164878820
Let's close this patch for now since there has not been activity for more than 3 months. We can always re-open it later if there is more interest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by smola <gi...@git.apache.org>.
Github user smola commented on a diff in the pull request:
https://github.com/apache/spark/pull/5483#discussion_r28703116
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataTypeParser.scala ---
@@ -27,7 +28,7 @@ import org.apache.spark.sql.catalyst.SqlLexical
* This is a data type parser that can be used to parse string representations of data types
* provided in SQL queries. This parser is mixed in with DDLParser and SqlParser.
*/
-private[sql] trait DataTypeParser extends StandardTokenParsers {
+private[sql] trait DataTypeParser extends StandardTokenParsers with PackratParsers {
--- End diff --
I'd get a stack overflow in my tests otherwise. I'll double check anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5483#issuecomment-137568826
@smola thanks for working on this? Do you have responses to the questions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5483#issuecomment-93303801
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30331/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5483#issuecomment-93262205
ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5483#issuecomment-92086073
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5483#discussion_r28402504
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataTypeParser.scala ---
@@ -67,6 +68,11 @@ private[sql] trait DataTypeParser extends StandardTokenParsers {
case tpe => ArrayType(tpe)
}
+ protected lazy val standardArrayType: PackratParser[DataType] =
+ (standardArrayType | primitiveType) <~ "(?i)array".r <~ ("[" ~ numericLit ~ "]").? ^^ {
--- End diff --
Having the capacity part in the syntax but ignoring them seems confusing. I'd suggest removing the capacity part. If we do decide to add this feature, we can add it back again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5483#discussion_r28402503
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataTypeParser.scala ---
@@ -27,7 +28,7 @@ import org.apache.spark.sql.catalyst.SqlLexical
* This is a data type parser that can be used to parse string representations of data types
* provided in SQL queries. This parser is mixed in with DDLParser and SqlParser.
*/
-private[sql] trait DataTypeParser extends StandardTokenParsers {
+private[sql] trait DataTypeParser extends StandardTokenParsers with PackratParsers {
--- End diff --
Why do we need `PackratParsers` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5483#issuecomment-96767344
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5483#issuecomment-93303793
[Test build #30331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30331/consoleFull) for PR 5483 at commit [`20b82de`](https://github.com/apache/spark/commit/20b82de3c8562f0f7cbe662469b984b09d3489f2).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6874][SQL] Support standard SQL syntax ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5483#issuecomment-93263680
[Test build #30331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30331/consoleFull) for PR 5483 at commit [`20b82de`](https://github.com/apache/spark/commit/20b82de3c8562f0f7cbe662469b984b09d3489f2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org