You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2023/07/27 16:31:13 UTC
[GitHub] [airflow] amoghrajesh opened a new pull request, #32888: Ordering the release command properly
amoghrajesh opened a new pull request, #32888:
URL: https://github.com/apache/airflow/pull/32888
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #32877
Due to the documentation, updating the version is done after the TAG is set for the release. We should re order it
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #32888: Order the release commands properly
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #32888:
URL: https://github.com/apache/airflow/pull/32888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #32888: Order the release commands properly
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #32888:
URL: https://github.com/apache/airflow/pull/32888#issuecomment-1655088275
I don’t think this will have much effect. Git tagging is done as part of the breeze release command earlier than this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #32888: Order the release commands properly
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #32888:
URL: https://github.com/apache/airflow/pull/32888#issuecomment-1655197789
It's done by the following command, earlier in the process:
```
breeze release-management start-rc-process ...
```
The source for the command is [here](https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/commands/release_candidate_command.py#L309), the `git_tag` fn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #32888: Order the release commands properly
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #32888:
URL: https://github.com/apache/airflow/pull/32888#issuecomment-1655970367
Thanks for that @potiuk
I didn't try to experience it this time because it looked like I didn't have rights to create or push packages.
But from your comment, it looks like I can try out the rest of the stuff at the very least. Will be mindful of it and try it out.
Apologies for the confusion the last time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #32888: Order the release commands properly
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #32888:
URL: https://github.com/apache/airflow/pull/32888#issuecomment-1655093210
Can you point me to it @pierrejeambrun?
I can fix it if thats the case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32888: Order the release commands properly
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32888:
URL: https://github.com/apache/airflow/pull/32888#issuecomment-1655966445
Yes. @amoghrajesh. Again - as I suggested before - you can try to PERFORM release process by following the guide and then you will see. what is going on and where you need to fix it. If you are attempting to fix it without actually following the release process, you are attempting to fix something theorethical. The ONLY way to improve the release process is to follow it and yourself and find the place where to fix it. This is pretty much an imperative. You really need to experience what's going on if you want to fix it.
You will not be able to push or publish the packages, but all the rest you will be able to do it with your own hands - otherwise you will make changes like the last time where you misunderstood what you need to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #32888: Order the release commands properly
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #32888:
URL: https://github.com/apache/airflow/pull/32888#issuecomment-1655659782
Thanks Pierre.
Can you point me to what you think is the issue? I can pick it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #32888: Order the release commands properly
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #32888:
URL: https://github.com/apache/airflow/pull/32888#issuecomment-1655949305
As I understand the reported issue, an idea would be to update the dockerfile airflow version when we upgrade the airflow version in the test-branch. (update `airflow/__init__.py`, `airflow/api_connexion/openapi/v1.yaml`, just before building the release note and running the `breeze start-rc-process`).
This way the tag will have the appropriate version in the dockerfile.
We already have a line:
```
Updating Dockerfile with the new version.
```
For updating main version, we also need this in the test branch I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org