You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "shwstppr (via GitHub)" <gi...@apache.org> on 2024/05/09 06:41:30 UTC
[PR] server: honor listall param for listiso api [cloudstack]
shwstppr opened a new pull request, #9064:
URL: https://github.com/apache/cloudstack/pull/9064
### Description
Fixes #8315
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2124283974
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2102059834
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9064?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.31%. Comparing base [(`87e7c57`)](https://app.codecov.io/gh/apache/cloudstack/commit/87e7c57d08c9ff87aa6c2db621efc620c7318a30?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4229c49`)](https://app.codecov.io/gh/apache/cloudstack/pull/9064?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 3 commits behind head on 4.19.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.19 #9064 +/- ##
============================================
- Coverage 14.96% 4.31% -10.65%
============================================
Files 5373 363 -5010
Lines 469005 29180 -439825
Branches 58953 5091 -53862
============================================
- Hits 70198 1260 -68938
+ Misses 391036 27778 -363258
+ Partials 7771 142 -7629
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9064/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9064/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.31% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9064/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9064?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2134141901
<b>[SF] Trillian test result (tid-10284)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47567 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9064-t10284-kvm-centos7.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_trigger_shutdown | `Failure` | 341.65 | test_safe_shutdown.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2102088426
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2102091111
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2118984073
<b>[SF] Trillian Build Failed (tid-10212)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2125982474
<b>[SF] Trillian test result (tid-10250)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52554 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9064-t10250-kvm-centos7.zip
Smoke tests completed. 127 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_events_resource | `Error` | 405.91 | test_events_resource.py
test_08_arping_in_ssvm | `Failure` | 5.22 | test_diagnostics.py
test_09_arping_in_cpvm | `Failure` | 5.27 | test_diagnostics.py
test_02_trigger_shutdown | `Failure` | 346.84 | test_safe_shutdown.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 410.44 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2123933388
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2132921433
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2133115190
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2102215916
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2132922563
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2123935091
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2118978917
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2118976000
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2124280811
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2133065985
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2133118779
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2134502044
`listIsos` now return all ISOs when `listall` is passed,
```
(local) 🐱 > list isos filter=id,name,ispublic,domainid
{
"count": 3,
"iso": [
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "79681074-a7bd-4434-befd-e7c5ad728ee7",
"ispublic": false,
"name": "test1"
},
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "fdeb66bc-57ac-491d-b4d8-c6a2545e064c",
"ispublic": false,
"name": "test1-dd"
},
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "77c5f629-4e8c-4b04-8fa2-5b08e4a4d8d7",
"ispublic": false,
"name": "ds"
}
]
}
(local) 🐱 > list isos filter=id,name,ispublic,domainid listall=true
{
"count": 9,
"iso": [
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "6c519636-3b2f-419c-b5bb-baac2c42ee5d",
"ispublic": true,
"name": "vmware-tools.iso"
},
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "afa5ca21-6bd1-4682-88bc-c0956606250e",
"ispublic": true,
"name": "xs-tools.iso"
},
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "aa621e5c-0689-412f-8b43-5976acdb404e",
"ispublic": true,
"name": "v1.26.0-Kubernetes-Binaries-ISO"
},
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "79681074-a7bd-4434-befd-e7c5ad728ee7",
"ispublic": false,
"name": "test1"
},
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "fdeb66bc-57ac-491d-b4d8-c6a2545e064c",
"ispublic": false,
"name": "test1-dd"
},
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "77c5f629-4e8c-4b04-8fa2-5b08e4a4d8d7",
"ispublic": false,
"name": "ds"
},
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "0bb30117-d53a-45e8-b2f5-65c17e635ff1",
"ispublic": true,
"name": "v1.24.0-Kubernetes-Binaries-ISO"
},
{
"domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
"id": "969111e5-c6f9-4d46-822f-31c7700ff4d3",
"ispublic": true,
"name": "v1.24.0-Kubernetes-Binaries-ISO"
},
{
"domainid": "db8c37e6-1e90-409b-addb-f1d8a9f77ce2",
"id": "ff67dfbe-1b2b-4dd2-9c7a-309d14a5fc37",
"ispublic": true,
"name": "test-domain-iso"
}
]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr merged PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server: honor listall param for listiso api [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9064:
URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2124126987
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org