You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stevedlawrence (via GitHub)" <gi...@apache.org> on 2024/01/17 17:17:37 UTC
[PR] Include the crossVersion in daffodil jars packaged in tar/zip/RPM [daffodil]
stevedlawrence opened a new pull request, #1147:
URL: https://github.com/apache/daffodil/pull/1147
The sbt-native-packager plugin does not include the crossVersion in the Daffodil jars that it packages in tar/zip/RPM/etc. This could be useful for more easily comparing jars from maven (which do include the crossVersion) or creating a local Ivy/maven repo.
The plugin does not have an configuration option to set this, so this directly modifies the mappings that the plugin creates to include the crossVersion for Daffodil jars only.
For example, a package mapping that was previously this:
lib/org.apache.daffodil.daffodil-lib-3.7.0.jar
is now changed to this:
lib/org.apache.daffodil.daffodil-lib_2.12-3.7.0.jar
DAFFODIL-2849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include the crossVersion in daffodil jars packaged in tar/zip/RPM [daffodil]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #1147:
URL: https://github.com/apache/daffodil/pull/1147#discussion_r1456206302
##########
daffodil-cli/build.sbt:
##########
@@ -36,6 +36,22 @@ Universal / mappings ++= Seq(
baseDirectory.value / "README.md" -> "README.md",
)
+// When the sbt-native-packger plugin creates a tar/zip/RPM/etc, it does not include the
+// crossVersion in mapping of jars built from this project (i.e. org.apache.daffodil jars only).
+// There are cases where this crossVersion would be useful (e.g. consistenncy with Ivy jar names
Review Comment:
Will fix.
> I wonder if we should file an issue with the sbt-native-packager maintainer
sbt-native-packager unfortunately seems pretty dead. PR's aren't getting merged and releases aren't being made (even though some tags have been created). I think whoever the maintainers are have lost interest/time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include the crossVersion in daffodil jars packaged in tar/zip/RPM [daffodil]
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on code in PR #1147:
URL: https://github.com/apache/daffodil/pull/1147#discussion_r1456184599
##########
daffodil-cli/build.sbt:
##########
@@ -36,6 +36,22 @@ Universal / mappings ++= Seq(
baseDirectory.value / "README.md" -> "README.md",
)
+// When the sbt-native-packger plugin creates a tar/zip/RPM/etc, it does not include the
+// crossVersion in mapping of jars built from this project (i.e. org.apache.daffodil jars only).
+// There are cases where this crossVersion would be useful (e.g. consistenncy with Ivy jar names
Review Comment:
*consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include the crossVersion in daffodil jars packaged in tar/zip/RPM [daffodil]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence merged PR #1147:
URL: https://github.com/apache/daffodil/pull/1147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org