You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/19 18:45:56 UTC

[GitHub] [airflow] XD-DENG commented on pull request #14900: Remove dags_folder path from dag.fileloc

XD-DENG commented on pull request #14900:
URL: https://github.com/apache/airflow/pull/14900#issuecomment-803038745


   Hi @JCoder01 , even though what you are referring to is not a new functionality, `fileloc` has been an absolute path along the way.
   
   What I would suggest are:
   - have a proper PR description here to share why this change is needed. If you didn't provide the link to the Issue, people (at least me) do not know where this PR's idea is coming from.
   - I would encourage more concrete discussion on whether the requirement/need raised in the Issue https://github.com/apache/airflow/issues/8061 has to be addressed in this way (or if this is the best way). I don't yet have a good proposal, hence I will cancel my review so that any other committer who finds this change good enough can merge.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org