You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org> on 2023/05/29 04:07:37 UTC

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9538: fix: replace mock tests with real tests in http logger

monkeyDluffy6017 commented on code in PR #9538:
URL: https://github.com/apache/apisix/pull/9538#discussion_r1208852379


##########
t/plugin/http-logger-log-format.t:
##########
@@ -438,7 +439,7 @@ done
                 [[{
                     "log_format": {
                         "host": "$host",
-                        "labels": "$a6_route_labels",
+                        "labels": "custom variable check",

Review Comment:
   Why you change this?



##########
t/plugin/http-logger-log-format.t:
##########
@@ -438,7 +439,7 @@ done
                 [[{
                     "log_format": {
                         "host": "$host",
-                        "labels": "$a6_route_labels",
+                        "labels": "custom variable check",

Review Comment:
   Why do you change this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org