You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2023/01/28 21:24:56 UTC
[maven-reporting-impl] branch master updated (936a3e4 -> 81de0c6)
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/maven-reporting-impl.git
from 936a3e4 Add TODOs
new 6172481 [MSHARED-1182] Drop incorrect usage of SinkEventAttributeSet#BOXED
new 9efad53 [MSHARED-1183] Don't pass implied args to AbstractMavenReportRenderer#startTable()
new 81de0c6 [MSHARED-1184] Drop unnecessary use of type attribute with JavaScript
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../maven/reporting/AbstractMavenReportRenderer.java | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
[maven-reporting-impl] 01/03: [MSHARED-1182] Drop incorrect usage of SinkEventAttributeSet#BOXED
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-reporting-impl.git
commit 61724819bdc0700e957925dd69317b0aee4caf5d
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sat Jan 28 21:48:42 2023 +0100
[MSHARED-1182] Drop incorrect usage of SinkEventAttributeSet#BOXED
---
.../org/apache/maven/reporting/AbstractMavenReportRenderer.java | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java b/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
index 7527ec7..0a5df13 100644
--- a/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
+++ b/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
@@ -20,7 +20,6 @@ package org.apache.maven.reporting;
*/
import org.apache.maven.doxia.sink.Sink;
-import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet;
import org.apache.maven.shared.utils.StringUtils;
@@ -375,8 +374,7 @@ public abstract class AbstractMavenReportRenderer
*/
protected void verbatimText( String text )
{
- // FIXME drop BOXED
- sink.verbatim( SinkEventAttributeSet.BOXED );
+ sink.verbatim( null );
text( text );
@@ -401,8 +399,7 @@ public abstract class AbstractMavenReportRenderer
}
else
{
- // FIXME drop BOXED
- sink.verbatim( SinkEventAttributeSet.BOXED );
+ sink.verbatim( null );
link( href, text );
[maven-reporting-impl] 02/03: [MSHARED-1183] Don't pass implied args to AbstractMavenReportRenderer#startTable()
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-reporting-impl.git
commit 9efad53f620f5749a06e58328528944bef8d353f
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sat Jan 28 21:49:37 2023 +0100
[MSHARED-1183] Don't pass implied args to AbstractMavenReportRenderer#startTable()
---
.../java/org/apache/maven/reporting/AbstractMavenReportRenderer.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java b/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
index 0a5df13..b8ab6e6 100644
--- a/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
+++ b/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
@@ -153,8 +153,7 @@ public abstract class AbstractMavenReportRenderer
*/
protected void startTable()
{
- // TODO pass null, since left is implied
- startTable( new int[] {Sink.JUSTIFY_LEFT}, false );
+ startTable( null, false );
}
/**
[maven-reporting-impl] 03/03: [MSHARED-1184] Drop unnecessary use of type attribute with JavaScript
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-reporting-impl.git
commit 81de0c6257af46cfc5bf9c349a170ebee38fe837
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sat Jan 28 21:57:21 2023 +0100
[MSHARED-1184] Drop unnecessary use of type attribute with JavaScript
---
.../java/org/apache/maven/reporting/AbstractMavenReportRenderer.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java b/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
index b8ab6e6..cd339d8 100644
--- a/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
+++ b/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
@@ -19,6 +19,7 @@ package org.apache.maven.reporting;
* under the License.
*/
+import org.apache.maven.doxia.markup.Markup;
import org.apache.maven.doxia.sink.Sink;
import org.apache.maven.shared.utils.StringUtils;
@@ -414,8 +415,7 @@ public abstract class AbstractMavenReportRenderer
*/
protected void javaScript( String jsCode )
{
- // TODO drop type, it is implied in HTML5
- sink.rawText( "<script type=\"text/javascript\">\n" + jsCode + "</script>" );
+ sink.rawText( Markup.EOL + "<script>" + Markup.EOL + jsCode + Markup.EOL + "</script>" + Markup.EOL );
}
/**