You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/06 08:42:00 UTC
[GitHub] [superset] toop opened a new pull request #13965: fixed FullSize charts broken #13600
toop opened a new pull request #13965:
URL: https://github.com/apache/superset/pull/13965
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
@junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814552700
Hi @toop,
please rebase the master branch and then force push to your owner repo branch, so that I can view your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (4ad4b71) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **decrease** coverage by `0.20%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 4ad4b71 differs from pull request most recent head ac71f7c. Consider uploading reports for the commit ac71f7c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
- Coverage 78.64% 78.44% -0.21%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
- Hits 37260 37162 -98
- Misses 9972 10069 +97
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <100.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.60% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <100.00%> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `80.48% <0.00%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <100.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...ac71f7c](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814372567
Tested locally, Pie, World map and Bar that reported broken previously are fixed. 🙏
The only thing I'm seeing thats abnormal is the backward button causes page crash. I don't think that's related to this PR since it's also happening in master. https://github.com/apache/superset/issues/13976
so LGTM.
https://user-images.githubusercontent.com/67837651/113765486-2f403380-96d1-11eb-9f68-3c18bec566f7.mov
@ktmud Jesse, can you help take a look at the code? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814566710
@toop, Your PR contains other PR changeset, please push this change relevant code only.
```
### tips
$ git checkout master
$ git checkout -b "new_branch"
### all changes should be based on "new_branch", then push the "new_branch" to your own remote repo.
$ git push --set-upstream origin
### you can create a new PR on the GitHub UI when you pushed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] toop closed pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
toop closed pull request #13965:
URL: https://github.com/apache/superset/pull/13965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (4ad4b71) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **increase** coverage by `0.04%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 4ad4b71 differs from pull request most recent head ac71f7c. Consider uploading reports for the commit ac71f7c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
+ Coverage 78.64% 78.69% +0.04%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
+ Hits 37260 37280 +20
+ Misses 9972 9951 -21
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `80.27% <100.00%> (-0.01%)` | :arrow_down: |
| mysql | `80.56% <100.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.59% <100.00%> (-0.01%)` | :arrow_down: |
| presto | `80.29% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `81.15% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `80.16% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `80.48% <0.00%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.76% <100.00%> (-0.02%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `88.72% <0.00%> (+0.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...ac71f7c](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fix: fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (75f9f24) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **decrease** coverage by `0.08%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head 75f9f24 differs from pull request most recent head 5b17512. Consider uploading reports for the commit 5b17512 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
- Coverage 78.64% 78.56% -0.09%
==========================================
Files 935 935
Lines 47375 47389 +14
Branches 5973 5971 -2
==========================================
- Hits 37260 37233 -27
- Misses 9972 10013 +41
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <33.33%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.25% <0.00%> (+0.76%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.88% <0.00%> (-5.43%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.34% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...5b17512](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] toop removed a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
toop removed a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814560394
It's done。 @zhaoyongjie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814566710
@toop, Your PR contains other PR changset, please push this change relevant code only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814372567
Tested locally, Pie, World map and Bar that reported broken previously are fixed. 🙏
The only thing I'm seeing thats abnormal is the backward button causes page crash. I don't think that's related to this PR since it's also happening in master. https://github.com/apache/superset/issues
so LGTM.
https://user-images.githubusercontent.com/67837651/113765486-2f403380-96d1-11eb-9f68-3c18bec566f7.mov
@ktmud Jesse, can you help take a look at the code? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fix: fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (a9278e3) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **decrease** coverage by `0.07%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head a9278e3 differs from pull request most recent head 5b17512. Consider uploading reports for the commit 5b17512 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
- Coverage 78.64% 78.57% -0.08%
==========================================
Files 935 935
Lines 47375 47389 +14
Branches 5973 5971 -2
==========================================
- Hits 37260 37237 -23
- Misses 9972 10009 +37
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <33.33%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.25% <0.00%> (+0.76%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.88% <0.00%> (-5.43%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.34% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `89.47% <0.00%> (+4.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...5b17512](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814566710
@toop, Your PR contains other PR changset, please push this change relevant code only.
```
### tips
$ git checkout master
$ git checkout -b "new_branch"
### all changes should be based on "new_branch", then push the "new_branch" to your own remote repo.
$ git push --set-upstream origin
### you can create a new PR on the GitHub UI when you pushed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (4ad4b71) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **decrease** coverage by `0.04%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 4ad4b71 differs from pull request most recent head ac71f7c. Consider uploading reports for the commit ac71f7c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
- Coverage 78.64% 78.60% -0.05%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
- Hits 37260 37239 -21
- Misses 9972 9992 +20
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `80.27% <100.00%> (-0.01%)` | :arrow_down: |
| mysql | `80.56% <100.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.59% <100.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.98% <100.00%> (-0.16%)` | :arrow_down: |
| sqlite | `80.16% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `80.48% <0.00%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.32% <100.00%> (-1.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.88% <0.00%> (-5.43%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...ac71f7c](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814552700
@toop
please rebase the master branch and then force push to your owner repo branch, so that I can view your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (4ad4b71) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **decrease** coverage by `0.24%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 4ad4b71 differs from pull request most recent head ac71f7c. Consider uploading reports for the commit ac71f7c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
- Coverage 78.64% 78.39% -0.25%
==========================================
Files 935 935
Lines 47375 47347 -28
Branches 5973 5956 -17
==========================================
- Hits 37260 37120 -140
- Misses 9972 10084 +112
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <100.00%> (-0.01%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.60% <100.00%> (-0.55%)` | :arrow_down: |
| sqlite | `80.16% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `80.48% <0.00%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.07% <100.00%> (-1.71%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `89.53% <0.00%> (-6.98%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...ac71f7c](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814372567
Tested locally, Pie, World map and Bar that reported broken previously are fixed. 🙏
The only thing I'm seeing thats abnormal is the backward button causes page crash. I don't think that's related to this PR.
so LGTM.
https://user-images.githubusercontent.com/67837651/113765486-2f403380-96d1-11eb-9f68-3c18bec566f7.mov
@ktmud Jesse, can you help take a look at the code? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814280528
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-815493527
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (4ad4b71) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **decrease** coverage by `0.20%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head 4ad4b71 differs from pull request most recent head ac71f7c. Consider uploading reports for the commit ac71f7c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
- Coverage 78.64% 78.44% -0.21%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
- Hits 37260 37162 -98
- Misses 9972 10069 +97
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <100.00%> (-0.01%)` | :arrow_down: |
| postgres | `80.59% <100.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.68% <100.00%> (-0.47%)` | :arrow_down: |
| sqlite | `80.16% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `80.48% <0.00%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <100.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.83% <0.00%> (-6.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...ac71f7c](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (a9278e3) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **decrease** coverage by `0.07%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head a9278e3 differs from pull request most recent head ac71f7c. Consider uploading reports for the commit ac71f7c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
- Coverage 78.64% 78.57% -0.08%
==========================================
Files 935 935
Lines 47375 47389 +14
Branches 5973 5971 -2
==========================================
- Hits 37260 37237 -23
- Misses 9972 10009 +37
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <33.33%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.25% <0.00%> (+0.76%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.88% <0.00%> (-5.43%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.34% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `89.47% <0.00%> (+4.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...ac71f7c](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814386794
@junlincc Ephemeral environment spinning up at http://52.40.162.39:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13965: fix: fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814280275
Hi @toop thank you so much for your contribution!
To help us better review and testing your PR, could you add 2-3 sentences description and BEFORE vs AFTER screenshot?
Also please get the checks passed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814552700
Hi @toop,
please rebase the master branch and then force push to your owner repo branch, so that I can review your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13965: fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (75f9f24) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **decrease** coverage by `1.68%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head 75f9f24 differs from pull request most recent head c79cd36. Consider uploading reports for the commit c79cd36 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
- Coverage 78.64% 76.96% -1.69%
==========================================
Files 935 935
Lines 47375 47387 +12
Branches 5973 5971 -2
==========================================
- Hits 37260 36470 -790
- Misses 9972 10739 +767
- Partials 143 178 +35
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `46.59% <33.33%> (-9.45%)` | :arrow_down: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `75.00% <0.00%> (-5.49%)` | :arrow_down: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| ... and [96 more](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...c79cd36](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814566710
@toop, Your PR contains other PR changset, please push this change relevant code only.
```
### tips
$ git checkout master
$ git checkout -b "new_branch"
### all changes should be based on "new_branch", then push the "new_branch" to your owner remote repo.
$ git push --set-upstream origin
### you can create a PR on the GitHub UI when you pushed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fix: fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
# [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=h1) Report
> Merging [#13965](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=desc) (a9278e3) into [master](https://codecov.io/gh/apache/superset/commit/f3becbeb4f54c27601e85554b0db7022f2532532?el=desc) (f3becbe) will **decrease** coverage by `0.72%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head a9278e3 differs from pull request most recent head 5b17512. Consider uploading reports for the commit 5b17512 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13965 +/- ##
==========================================
- Coverage 78.64% 77.92% -0.73%
==========================================
Files 935 935
Lines 47375 47388 +13
Branches 5973 5971 -2
==========================================
- Hits 37260 36925 -335
- Misses 9972 10300 +328
- Partials 143 163 +20
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.68% <33.33%> (+0.64%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `75.00% <0.00%> (-5.49%)` | :arrow_down: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `42.85% <0.00%> (-40.00%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `46.47% <0.00%> (-19.72%)` | :arrow_down: |
| ... and [45 more](https://codecov.io/gh/apache/superset/pull/13965/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=footer). Last update [f3becbe...5b17512](https://codecov.io/gh/apache/superset/pull/13965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814566710
@toop, Your PR contains other PR changset, please push this change relevant code only.
```
### tips
$ git checkout master
$ git checkout -b "new_branch"
### all changes should be based on "new_branch", then push the "new_branch" to your own remote repo.
$ git push --set-upstream origin
### you can create a PR on the GitHub UI when you pushed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814372567
Tested locally, Pie, World map and Bar that reported broken previously are fixed. 🙏
The only thing I'm seeing thats abnormal is the backward button causes page crash. I don't think that's related to this PR.
so LGTM.
@ktmud Jesse, can you help take a look at the code? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13965: fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-813955537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13965: fix: fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814280528
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] toop commented on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
toop commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814558497
It's done。 @zhaoyongjie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13965: fix: fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814280275
Hi @toop thank you so much for your contribution!
To help us better review and testing your PR, could you add 2-3 sentences description, manual testing plan and BEFORE vs AFTER screenshot?
Also please get the checks passed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] toop commented on pull request #13965: fix(dashboard): fixed FullSize charts broken #13600
Posted by GitBox <gi...@apache.org>.
toop commented on pull request #13965:
URL: https://github.com/apache/superset/pull/13965#issuecomment-814560394
It's done。 @zhaoyongjie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org