[GitHub] trongrg edited a comment on issue #199: Fix js error "The parameter is incorrect"

[GitBox <gi...@apache.org>]

trongrg edited a comment on issue #199: Fix js error "The parameter is incorrect"
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/199#issuecomment-413461134
 
 
   "download.progress.bytesReceived is 0" means the image is downloaded, but on hard disk its size is 0. This could be the result of a broken transfer.
   
   I didn't swallow the exception (it is hard to digest anyway). This exception was thrown by a bug in the code, not intentional.
   
   The purpose of that piece of code is to resolve a FILE_NOT_FOUND_ERR, with the downloaded payload. So it try to load the downloaded bytes, however when the bytesReceived is 0, WinJS throws an exception, and break the callback
   
   After the change, it still resolves a FILE_NOT_FOUND_ERR, just without a payload in case bytesReceived is 0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org