You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/09/04 02:34:21 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #8830: [INLONG-8829][Manager] Support configuring whether to use zookeeper by request
fuweng11 opened a new pull request, #8830:
URL: https://github.com/apache/inlong/pull/8830
### Prepare a Pull Request
- Fixes #8829
### Motivation
Support configuring whether to use zookeeper by request.
### Modifications
Support configuring whether to use zookeeper by request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #8830: [INLONG-8829][Manager] Support configuring whether to use zookeeper by request
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #8830:
URL: https://github.com/apache/inlong/pull/8830#discussion_r1314388183
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -155,7 +155,9 @@ public String save(InlongGroupRequest request, String operator) {
throw new BusinessException(ErrorCodeEnum.GROUP_DUPLICATE);
}
- request.setEnableZookeeper(enableZookeeper ? InlongConstants.ENABLE_ZK : InlongConstants.DISABLE_ZK);
+ if (request.getEnableZookeeper() == null) {
Review Comment:
```suggestion
if (request.getEnableZookeeper() == null) {
``` request.setEnableZookeeper = request.getEnableZookeeper() == null ? enableZokeeper : request.getEnableZookeeper();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #8830: [INLONG-8829][Manager] Support configuring whether to use zookeeper by request
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #8830:
URL: https://github.com/apache/inlong/pull/8830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org