You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "benjaminle22 (via GitHub)" <gi...@apache.org> on 2026/06/11 08:40:06 UTC
[PR] test(frontend): expand OperatorReuseCacheStatusService spec coverage [texera]
benjaminle22 opened a new pull request, #5624:
URL: https://github.com/apache/texera/pull/5624
### What changes were proposed in this PR?
Expands the existing spec for `OperatorReuseCacheStatusService`, which previously only checked `should be created`. Adds behavior-focused tests covering both constructor subscriptions: the `CacheStatusUpdateEvent` websocket handler and the `getReuseCacheOperatorsChangedStream` handler. Tests verify that `JointUIService.changeOperatorReuseCacheStatus` is called correctly for each operator, that the `mainJointPaper` null guard is respected in both handlers, and that empty operator lists do not throw.
### Any related issues, documentation, discussions?
Closes #5543
### How was this PR tested?
New tests run via `yarn test -- operator-reuse-cache-status` and `yarn lint`. 6 tests passing.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude (Claude Sonnet 4.6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): expand OperatorReuseCacheStatusService spec coverage [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5624:
URL: https://github.com/apache/texera/pull/5624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): expand OperatorReuseCacheStatusService spec coverage [texera]
Posted by "benjaminle22 (via GitHub)" <gi...@apache.org>.
benjaminle22 commented on PR #5624:
URL: https://github.com/apache/texera/pull/5624#issuecomment-4678759382
/request-review @Ma77Ball
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): expand OperatorReuseCacheStatusService spec coverage [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5624:
URL: https://github.com/apache/texera/pull/5624#issuecomment-4687663475
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5624?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 52.53%. Comparing base ([`ae3128d`](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`88aceb3`](https://app.codecov.io/gh/apache/texera/commit/88aceb3a63f9182aaf7ecb5a427b731624b98ed0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5624 +/- ##
============================================
- Coverage 52.53% 52.53% -0.01%
Complexity 2483 2483
============================================
Files 1071 1071
Lines 41363 41363
Branches 4441 4441
============================================
- Hits 21731 21728 -3
- Misses 18357 18359 +2
- Partials 1275 1276 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.61% <ø> (ø)` | | Carriedforward from [ae3128d](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [ae3128d](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.29% <ø> (ø)` | | Carriedforward from [ae3128d](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <ø> (ø)` | | Carriedforward from [ae3128d](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.71% <ø> (ø)` | | Carriedforward from [ae3128d](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <ø> (ø)` | | Carriedforward from [ae3128d](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.17% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.72% <ø> (ø)` | | Carriedforward from [ae3128d](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.75% <ø> (ø)` | | Carriedforward from [ae3128d](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | Carriedforward from [ae3128d](https://app.codecov.io/gh/apache/texera/commit/ae3128d999c48d0f014be2eea2eb4fc0f4ee9e66?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5624?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org