You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ivanzlenko (via GitHub)" <gi...@apache.org> on 2025/12/17 11:01:08 UTC
[PR] IGNITE-27149 Add additional logging for incoming snapshot [ignite-3]
ivanzlenko opened a new pull request, #7260:
URL: https://github.com/apache/ignite-3/pull/7260
https://issues.apache.org/jira/browse/IGNITE-27149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27149 Add additional logging for incoming snapshot [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #7260:
URL: https://github.com/apache/ignite-3/pull/7260#discussion_r2626608193
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/incoming/IncomingSnapshotReader.java:
##########
@@ -22,25 +22,26 @@
import org.apache.ignite.raft.jraft.entity.RaftOutter.SnapshotMeta;
import org.apache.ignite.raft.jraft.rpc.Message;
import org.apache.ignite.raft.jraft.storage.snapshot.SnapshotReader;
+import org.jetbrains.annotations.Nullable;
/**
* Snapshot reader implementation to read the metadata of downloaded snapshot.
*/
class IncomingSnapshotReader extends SnapshotReader {
/** Snapshot meta. */
- private final PartitionSnapshotMeta snapshotMeta;
+ private final @Nullable PartitionSnapshotMeta snapshotMeta;
Review Comment:
https://github.com/apache/ignite-3/pull/7259
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/snapshot/SnapshotReader.java:
##########
@@ -28,7 +28,7 @@ public abstract class SnapshotReader extends Snapshot implements Closeable, Life
/**
* Load the snapshot metadata.
*/
- public abstract SnapshotMeta load();
+ public abstract @Nullable SnapshotMeta load();
Review Comment:
https://github.com/apache/ignite-3/pull/7259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27149 Add additional logging for incoming snapshot [ignite-3]
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #7260:
URL: https://github.com/apache/ignite-3/pull/7260#discussion_r2627087077
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -307,6 +311,8 @@ public boolean isVolatile() {
@Override
public CompletableFuture<Void> startRebalancePartition(int partitionId) {
return busy(() -> mvPartitionStorages.startRebalance(partitionId, mvPartitionStorage -> {
+ LOG.info("Starting rebalance for partition [tableId={}, partitionId={}]", getTableId(), partitionId);
Review Comment:
Here too
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/incoming/IncomingSnapshotCopier.java:
##########
@@ -218,11 +225,34 @@ public void start() {
}
private CompletableFuture<?> waitForMetadataWithTimeout(PartitionSnapshotMeta snapshotMeta) {
+ snapshotStats.onWaitingCatalogPhaseStart();
+
+ if (LOG.isInfoEnabled()) {
+ LOG.info(
+ "Waiting for catalog version [snapshotId={}, {}, catalogVersion={}]",
+ snapshotUri.snapshotId,
+ createPartitionInfo(),
+ snapshotMeta.requiredCatalogVersion()
+ );
+ }
+
CompletableFuture<?> metadataReadyFuture = partitionSnapshotStorage.catalogService()
.catalogReadyFuture(snapshotMeta.requiredCatalogVersion());
CompletableFuture<?> readinessTimeoutFuture = completeOnMetadataReadinessTimeout();
- return anyOf(metadataReadyFuture, readinessTimeoutFuture);
+ return anyOf(metadataReadyFuture, readinessTimeoutFuture)
+ .whenComplete((ignored, throwable) -> {
+ snapshotStats.onWaitingCatalogPhaseEnd();
+
+ if (LOG.isInfoEnabled()) {
+ LOG.info(
+ "Finished waiting for the catalog readiness [snapshotId={}, {}, waitingTime={}ms]",
Review Comment:
Let's also write an outcome - was it a timeout or an actual readiness. It depends on the state of futures in `anyOf`
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java:
##########
@@ -292,6 +296,8 @@ private void busy(Runnable action) {
@Override
public CompletableFuture<Void> startRebalancePartition(int partitionId) {
return busy(() -> mvPartitionStorages.startRebalance(partitionId, mvPartitionStorage -> {
+ LOG.info("Starting rebalance for partition [tableId={}, partitionId={}]", getTableId(), partitionId);
Review Comment:
Let's also guard it with `if (LOG.isInfoEnabled()) {` just in case, why not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27149 Add additional logging for incoming snapshot [ignite-3]
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov merged PR #7260:
URL: https://github.com/apache/ignite-3/pull/7260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org