You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sgromme (via GitHub)" <gi...@apache.org> on 2023/12/07 14:58:41 UTC
[PR] Add Codespace with Breeze [airflow]
sgromme opened a new pull request, #36109:
URL: https://github.com/apache/airflow/pull/36109
- new style devcontainer.json
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add devcontainer\Codespace with Breeze [airflow]
Posted by "sgromme (via GitHub)" <gi...@apache.org>.
sgromme commented on PR #36109:
URL: https://github.com/apache/airflow/pull/36109#issuecomment-1846087963
Github Codespaces has around ~50 hours free for each month vs Gitpods around ~ 5 hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add devcontainer\Codespace with Breeze [airflow]
Posted by "sgromme (via GitHub)" <gi...@apache.org>.
sgromme commented on PR #36109:
URL: https://github.com/apache/airflow/pull/36109#issuecomment-1846205603
Ok, I see what you mean. Canceling and will fix the existing devcontainers and update the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add devcontainer\Codespace with Breeze [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36109:
URL: https://github.com/apache/airflow/pull/36109#issuecomment-1846133474
Well. that's what the original devcontainer was supposed to do . What's the difference? We already have support for codes[aces, so my question is:
a) does it fix something broken?
b) does it add anythong new we did not have?
Look at the links I sent you. My question is what is the scope of the change you propose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add devcontainer\Codespace with Breeze [airflow]
Posted by "sgromme (via GitHub)" <gi...@apache.org>.
sgromme commented on PR #36109:
URL: https://github.com/apache/airflow/pull/36109#issuecomment-1846070431
- Added the new Breeze devcontainer(Codespace) for Breeze support - integration and testing ( like Gitpod.io)
- CONTRIBUTORS_QUICK_START_CODESPACES.rst will be updated next
- /.devcontainer devcontainer.json files (qty 3) will be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add devcontainer\Codespace with Breeze [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36109:
URL: https://github.com/apache/airflow/pull/36109#issuecomment-1846136118
> Github Codespaces has around ~50 hours free for each month vs Gitpods around ~ 5 hours.
You completely missed the point. I linked you the "codespaces" support not Github - you seem to be adding what we already have (might be broken, but fixing if it is, is the right way, not adding another devcontainer.json when we already have one that starts breeze in codespaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add devcontainer\Codespace with Breeze [airflow]
Posted by "sgromme (via GitHub)" <gi...@apache.org>.
sgromme commented on PR #36109:
URL: https://github.com/apache/airflow/pull/36109#issuecomment-1846208405
Instead of adding new code will fix the devcontainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add devcontainer\Codespace with Breeze [airflow]
Posted by "sgromme (via GitHub)" <gi...@apache.org>.
sgromme closed pull request #36109: Add devcontainer\Codespace with Breeze
URL: https://github.com/apache/airflow/pull/36109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org