[GitHub] ccollins476ad commented on issue #365: nimble/controller: Remove not working restrictions

[gi...@git.apache.org]

ccollins476ad commented on issue #365: nimble/controller: Remove not working restrictions
URL: https://github.com/apache/mynewt-core/pull/365#issuecomment-312332686
 
 
   I know this has already been merged, but I just wanted to mention that you can still keep the restrictions.  You would do this as follows:
   
   ```
   syscfg.defs:
       BLE_LL_CFG_FEAT_LL_EXT_ADV:
           description: >
               This option is used to enable/disable support for Extended
               Advertising Feature. That means extended scanner, advertiser
               and connect.
           value: 0
           restrictions:
               - 'BLE_EXT_ADV if 1'
               - '!BLE_EXT_ADV if 0'
   
   syscfg.vals.BLE_EXT_ADV:
       BLE_LL_CFG_FEAT_LL_EXT_ADV: 1
   ```
   
   I think using "MYNEWT_VAL..." as a setting's default value is not desirable.  It takes advantage of knowledge of how newt generates setting names, and if you get the name wrong (or if the setting never gets defined), you'll get strange compiler errors that may be difficult to debug.
   
   Anyway, I don't think it is necessary to change this now; this is more of an "fyi" for future changes.
   
   I think the real fix is to improve the syscfg system to allow full expressions.  I started doing some work on this, but we won't get it into 1.1.  So, we are stuck with several lame solutions for now :).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services