You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/26 03:40:25 UTC
[GitHub] [pulsar] AnonHxy opened a new pull request, #16221: [PIP-149][broker]Make getList async
AnonHxy opened a new pull request, #16221:
URL: https://github.com/apache/pulsar/pull/16221
Master Issue: https://github.com/apache/pulsar/issues/14365
### Motivation
* See https://github.com/apache/pulsar/issues/14365
### Modifications
* Make getList async
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908452575
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4271,12 +4271,17 @@ private CompletableFuture<Topic> topicNotFoundReasonAsync(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
throw new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ }
+ return null;
Review Comment:
`thenAccept ` is better to avoid returning null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#issuecomment-1166886837
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #16221: [improve][PIP-149][broker]Make getList async
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#issuecomment-1166473657
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908188120
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,8 +4243,16 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
- return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ } else {
+ try {
+ if (!internalGetListAsync(Optional.empty())
+ .get(pulsar().getConfiguration().getMetadataStoreOperationTimeoutSeconds(), TimeUnit.SECONDS)
+ .contains(topicName.toString())) {
+ return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ }
+ } catch (Exception e) {
+ // failed to get reason, so fall through coarse reason
Review Comment:
en...It seems that `e.getMessage` is not the real reason I think @nodece , Please take a look also @Technoboy- @Jason918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908451328
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,8 +4243,16 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
- return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ } else {
+ try {
+ if (!internalGetListAsync(Optional.empty())
+ .get(pulsar().getConfiguration().getMetadataStoreOperationTimeoutSeconds(), TimeUnit.SECONDS)
+ .contains(topicName.toString())) {
+ return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ }
+ } catch (Exception e) {
+ // failed to get reason, so fall through coarse reason
Review Comment:
I think you can add a new sync method called `internalGetList` like `getPartitionedTopicMetadata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908467246
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,8 +4243,16 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
- return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ } else {
+ try {
+ if (!internalGetListAsync(Optional.empty())
+ .get(pulsar().getConfiguration().getMetadataStoreOperationTimeoutSeconds(), TimeUnit.SECONDS)
+ .contains(topicName.toString())) {
+ return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ }
+ } catch (Exception e) {
+ // failed to get reason, so fall through coarse reason
Review Comment:
In order to reduce the duplicated codes, you can do it like sync(() -> internalGetListAsync()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r907999571
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if (!internalGetListAsync(Optional.empty()).join().contains(topicName.toString())) {
Review Comment:
We need to avoid using the `join()` and `get()`.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4271,7 +4263,7 @@ private CompletableFuture<Topic> topicNotFoundReasonAsync(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
throw new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if (!internalGetListAsync(Optional.empty()).join().contains(topicName.toString())) {
Review Comment:
We need to avoid using the `join()` and `get()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908073601
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if (!internalGetListAsync(Optional.empty()).join().contains(topicName.toString())) {
Review Comment:
It looks like you need to make the `topicNotFoundReason` to async.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r907999571
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if (!internalGetListAsync(Optional.empty()).join().contains(topicName.toString())) {
Review Comment:
We need to avoid to using the `join()` and `get()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908466265
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if (!internalGetListAsync(Optional.empty()).join().contains(topicName.toString())) {
Review Comment:
sync(() -> topicNotFoundReasonAsync()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 merged pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
Jason918 merged PR #16221:
URL: https://github.com/apache/pulsar/pull/16221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908452575
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4271,12 +4271,17 @@ private CompletableFuture<Topic> topicNotFoundReasonAsync(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
throw new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ }
+ return null;
Review Comment:
`thenAccept ` is better to avoid returning null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908178125
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,8 +4243,16 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
- return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ } else {
+ try {
+ if (!internalGetListAsync(Optional.empty())
+ .get(pulsar().getConfiguration().getMetadataStoreOperationTimeoutSeconds(), TimeUnit.SECONDS)
+ .contains(topicName.toString())) {
+ return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ }
+ } catch (Exception e) {
+ // failed to get reason, so fall through coarse reason
Review Comment:
I think we should throw an error, or return `return new RestException(Status.NOT_FOUND, e.getMessage());`
You can look at other people's opinions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908458096
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,8 +4243,16 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
- return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ } else {
+ try {
+ if (!internalGetListAsync(Optional.empty())
+ .get(pulsar().getConfiguration().getMetadataStoreOperationTimeoutSeconds(), TimeUnit.SECONDS)
+ .contains(topicName.toString())) {
+ return new RestException(Status.NOT_FOUND, "Topic partitions were not yet created");
+ }
+ } catch (Exception e) {
+ // failed to get reason, so fall through coarse reason
Review Comment:
It looks bettter to keep the original `internalGetList`, and cleanup it until making all other methods async @Technoboy-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908126816
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4271,7 +4263,7 @@ private CompletableFuture<Topic> topicNotFoundReasonAsync(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
throw new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if (!internalGetListAsync(Optional.empty()).join().contains(topicName.toString())) {
Review Comment:
Thanks @nodece , I removed `join` in `topicNotFoundReasonAsync`. PTAL
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if (!internalGetListAsync(Optional.empty()).join().contains(topicName.toString())) {
Review Comment:
There has existed a method `topicNotFoundReasonAsync`, but `topicNotFoundReason` are still invoked by `getTopicReference`, which appears in many methods. I think it's better to cleanup `topicNotFoundReason` when other methods have replaced `getTopicReference` with `getTopicReferenceAsync`.So it's looks OK using `join` here @nodece
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908146639
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if (!internalGetListAsync(Optional.empty()).join().contains(topicName.toString())) {
Review Comment:
Ok, it's better using `get(pulsar().getConfiguration().getMetadataStoreOperationTimeoutSeconds(), TimeUnit.SECONDS)` instead of `join()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#issuecomment-1166521976
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on a diff in pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r908061231
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicName topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s", topicName.toString(), topicErrorType));
- } else if (!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if (!internalGetListAsync(Optional.empty()).join().contains(topicName.toString())) {
Review Comment:
Should we keep both `internalGetList ` and `internalGetListAsync`? @nodece
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#issuecomment-1169896794
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #16221: [improve][broker][PIP-149]Make getList async
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#issuecomment-1169455675
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org