[jira] [Commented] (CODEC-225) InputStream not closed

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CODEC-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486887#comment-15486887 ] 

ASF GitHub Bot commented on CODEC-225:
--------------------------------------

GitHub user SvetlinZarev opened a pull request:

    https://github.com/apache/commons-codec/pull/5

    Do not leak file descriptors

    Bug: CODEC-225

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SvetlinZarev/commons-codec StreamLeaks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-codec/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit b93405af5abb1f59c87e49d271c4f39ab034868b
Author: Svetlin Zarev <sv...@sap.com>
Date:   2016-09-13T10:29:17Z

    Do not leak file descriptors
    
    Bug: CODEC-225

----


> InputStream not closed
> ----------------------
>
>                 Key: CODEC-225
>                 URL: https://issues.apache.org/jira/browse/CODEC-225
>             Project: Commons Codec
>          Issue Type: Bug
>            Reporter: Svetlin Zarev
>
> After running static code analysis on common codecs we discovered that it leaks file descriptors. The relevant locations are:
> * DaitchMokotoffSoundex -> the static initializer on line 229 
> * Rule -> the static initializer on line 212 and the parseRules() method on line 438.
> patch provided via github pull request.
> This issue is relevant for web app deployments on OSes (like windows) that lock the files if ther eare open streams to them, and will prevent application undeployment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)